Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mds, client: fix locking around handle_conf_change #7312

Merged
merged 6 commits into from Jan 29, 2016
Merged

mds, client: fix locking around handle_conf_change #7312

merged 6 commits into from Jan 29, 2016

Commits on Jan 21, 2016

  1. vstart: enable lockdep 

    Development clusters are the right place to enable
performance-degrading correctness checks.

Signed-off-by: John Spray <john.spray@redhat.com>
    John Spray committed Jan 21, 2016
    Configuration menu
    Copy the full SHA
    fb6dea3 View commit details
    Browse the repository at this point in the history

  2. mds: Fix lock ordering around asok registration 

    Because we acquire mds_lock inside asok handlers,
we must not hold mds_lock while registering our commands.

Fixes: ceph#14374
Signed-off-by: John Spray <john.spray@redhat.com>
    John Spray committed Jan 21, 2016
    Configuration menu
    Copy the full SHA
    26d1032 View commit details
    Browse the repository at this point in the history

  3. cmake: fix libcephfs linking 

    This was a merge glitch between Ali's cmake
updates and my VolumeClient PR.  My PR
was using the old TCMALLOC_LIBS vs. the
new ALLOC_LIBS variable.

Signed-off-by: John Spray <john.spray@redhat.com>
    John Spray committed Jan 21, 2016
    Configuration menu
    Copy the full SHA
    f4b0b2f View commit details
    Browse the repository at this point in the history

  4. client: take lock in handle_conf_change 

    Fixes: ceph#14365
Signed-off-by: John Spray <john.spray@redhat.com>
    John Spray committed Jan 21, 2016
    Configuration menu
    Copy the full SHA
    94d1aa2 View commit details
    Browse the repository at this point in the history

  5. client: don't hold client_lock around objecter init 

    Because by doing so we establish a dependency
between client lock and admin socket lock.

Signed-off-by: John Spray <john.spray@redhat.com>
    John Spray committed Jan 21, 2016
    Configuration menu
    Copy the full SHA
    448bea4 View commit details
    Browse the repository at this point in the history

  6. mds: fix locking around handle_conf_change 

    We have to be careful about holding mds_lock
while setting things up, and we also have
to handle either locked or unlocked
calls to handle_conf_change.

Signed-off-by: John Spray <john.spray@redhat.com>
    John Spray committed Jan 21, 2016
    Configuration menu
    Copy the full SHA
    e430f8e View commit details
    Browse the repository at this point in the history