New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rgw: adjust the request_uri to support absoluteURI of http request #7675
Conversation
My updated comment is, it would be useful to describe in the commit msg or source how the need for this arises, and what a candidate URL being transformed is. Thanks! |
The originated cause for this issue described in the tracker http://tracker.ceph.com/issues/12917. Refer to aws/aws-sdk-go#344, you can find the example. And for the absoluteURI scenario, the variables reaching RGW are as below: |
@VMCloud can you modify the commit description to include your last comment? |
http://tracker.ceph.com/issues/12917 Fixes: ceph#12917 The requestURI transferred from the frontend can be abs_path or absoluteURI If it is absoluteURI, we should adjust it to abs_path for the following S3 authorization and some other processes depending on the requestURI The absoluteURI can start with "http://", "https://", "ws://" or "wss://" Signed-off-by: Wenjun Huang <wenjunhuang@tencent.com>
06a93ec
to
70f32f9
Compare
Hi @yehudasa, I have updated the commit description, thanks! |
This passed my S3 smoke tests |
rgw: adjust the request_uri to support absoluteURI of http request
I tested jewel containing this PR with example listObject.go from aws-sdk-go. This client sent absolute URI in HTTP Header and it still hit issue http://tracker.ceph.com/issues/12917 This PR only affect code since civetweb_callback, however process_new_connection in civetweb still check uri and failed on absolute uri. Backtrace should looks like
We'd still need fix from civetweb: civetweb/civetweb#197 |
I was trying to use AWS Go SDK against Ceph (in a version where this fix is already there) and still this is not working. |
http://tracker.ceph.com/issues/12917 Fixes: #12917
Signed-off-by: Wenjun Huang wenjunhuang@tencent.com
Continuously discuss for the original pull request #5774