rgw: adjust the request_uri to support absoluteURI of http request #5774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
wenjun-huang
force-pushed
the
wip-12917
branch
2 times, most recently
from
59e5a0a
to
9bb9260
Compare
|
Hi, @dachary |
|
@VMCloud thanks :-) |
| static string get_abs_path(const string &request_uri) { | ||
| int beg_pos = request_uri.find("://") + 3; | ||
| int len = request_uri.size(); | ||
| while(beg_pos < len) { |
There was a problem hiding this comment.
Yes, it is a good suggestion.
wenjun-huang
force-pushed
the
wip-12917
branch
from
9bb9260
to
625f629
Compare
yehudasa
added a commit
that referenced
this pull request
Sep 29, 2015
wenjun-huang
force-pushed
the
wip-12917
branch
4 times, most recently
from
26dc423
to
e34cead
Compare
wenjun-huang
force-pushed
the
wip-12917
branch
from
e34cead
to
4e12251
Compare
http://tracker.ceph.com/issues/12917 Fixes: ceph#12917 Signed-off-by: Wenjun Huang <wenjunhuang@tencent.com>
wenjun-huang
force-pushed
the
wip-12917
branch
from
4e12251
to
63be569
Compare
|
@cbodley @yehudasa @mattbenjamin needs review? |
| // S3 authorization and some other processes depending on the requestURI | ||
| // The absoluteURI can start with "http://", "https://", "ws://" or "wss://" | ||
| static string get_abs_path(const string& request_uri) { | ||
| const string ABS_PREFIXS[] = {"http://", "https://", "ws://", "wss://"}; |
There was a problem hiding this comment.
can we make this array static so we don't construct the std::strings on every call?
|
Have made the const array static |
|
@VMCloud did you removed your remote branch of wip-12917 by accident? as a side effect, it closes the pull request automatically. |
|
@tchaikov yes, I am trying to reopen it. |
|
I have recreate a PR for this bug: #7675 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/12917 Fixes: #12917
Signed-off-by: Wenjun Huang wenjunhuang@tencent.com