osd: filestore: fix wrong scope of result code for error cases during mkfs #7704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During the mkfs process, if we fail to read and sometimes rewrite the op_seq, the mkfs process is abnormally terminated but we may still return a positive answer to the caller, which is misleading. This patch is provided to solve the above problems by correctly setting 'ret' correspondingly under these cases, which is the final answer to be passed out for caller. Fixes: ceph#14814 Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
xiexingguo
added a commit
to xiexingguo/ceph
that referenced
this pull request
Feb 19, 2016
…ount This pr is similar to ceph#7704 but I feel like making a new one in case they need to be treated separately, such as one needs to be backported while the other does not, and vice versa. During the mount process, if we fail to read op_seq or create a no-snap-fn, the mount process is abnormally terminated but we may still return a positive answer to the caller, which is misleading. This patch is provided to solve the above problems by correctly setting 'ret' correspondingly under these cases, which is the final answer to be passed out for caller. Fixes: ceph#14815 Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
liewegas
changed the title
liewegas
added a commit
that referenced
this pull request
Mar 2, 2016
osd: filestore: fix wrong scope of result code for error cases during mkfs Reviewed-by: Sage Weil <sage@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the mkfs process, if we fail to read and sometimes rewrite the
op_seq, the mkfs process is abnormally terminated but we may
still return a positive answer to the caller, which is confusing and misleading.
This patch is provided to solve the above problems by correctly setting
'ret' correspondingly under these two cases, which is the final answer to
be passed out to caller.
Fixes: #14814
Signed-off-by: xie xingguo xie.xingguo@zte.com.cn