osd: switch filestore to default to rocksdb #14814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liewegas
reviewed
Apr 26, 2017
src/common/config_opts.h
Outdated
| @@ -1164,7 +1164,8 @@ OPTION(kstore_onode_map_size, OPT_U64, 1024) | |||
| OPTION(kstore_cache_tails, OPT_BOOL, true) | |||
| OPTION(kstore_default_stripe_size, OPT_INT, 65536) | |||
|
|
|||
| OPTION(filestore_omap_backend, OPT_STR, "leveldb") | |||
| /// change default from leveldb to rocksdb | |||
There was a problem hiding this comment.
don't need this comment; source file reflects how things are, not how they got that way
Signed-off-by: Neha Ojha <nojha@redhat.com>
neha-ojha
force-pushed
the
wip-osd-filestore-default
branch
from
ba2f02a
to
ba96197
Compare
liewegas
approved these changes
Apr 26, 2017
|
@liewegas we'll want a release note explaining why this was done too - namely for multithreaded compaction |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request aims to switch filestore to default to rocksdb instead of leveldb.
Signed-off-by: Neha Ojha nojha@redhat.com