New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osd: switch filestore to default to rocksdb #14814

Merged
merged 1 commit into from Apr 27, 2017

Conversation

Projects
None yet
3 participants
@neha-ojha
Member

neha-ojha commented Apr 26, 2017

This pull request aims to switch filestore to default to rocksdb instead of leveldb.

Signed-off-by: Neha Ojha nojha@redhat.com

@liewegas liewegas added the core label Apr 26, 2017

@@ -1164,7 +1164,8 @@ OPTION(kstore_onode_map_size, OPT_U64, 1024)
OPTION(kstore_cache_tails, OPT_BOOL, true)
OPTION(kstore_default_stripe_size, OPT_INT, 65536)
OPTION(filestore_omap_backend, OPT_STR, "leveldb")
/// change default from leveldb to rocksdb

This comment has been minimized.

@liewegas

liewegas Apr 26, 2017

Member

don't need this comment; source file reflects how things are, not how they got that way

This comment has been minimized.

@neha-ojha

neha-ojha Apr 26, 2017

Member

Fixed it.

@liewegas liewegas added the needs-qa label Apr 26, 2017

osd: switch filestore to default to rocksdb
Signed-off-by: Neha Ojha <nojha@redhat.com>

@liewegas liewegas merged commit 559a7a8 into ceph:master Apr 27, 2017

@jdurgin

This comment has been minimized.

Member

jdurgin commented Apr 27, 2017

@liewegas we'll want a release note explaining why this was done too - namely for multithreaded compaction

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment