librbd: journal replay needs to support re-executing maintenance ops #7785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm |
|
Needs to fix ImageReplayer()'s use of journal: 8ca269f |
added 5 commits
March 1, 2016 07:38
Ignore errors that are to be expected when replaying a maintenance op two or more times. Fixes: ceph#14822 Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
If the start event is flagged as committed before the op is actually executed, librbd won't be able to replay the event should a crash occur. Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
If a client recorded a maintenance op to the journal but crashed before writing the op finish event, the image will be in an inconsistent state. Therefore, once the end of the journal is reached, attempt to apply all queued ops. Fixes: ceph#14822 Signed-off-by: Jason Dillaman <dillaman@redhat.com>
|
done |
jdurgin
added a commit
that referenced
this pull request
Mar 2, 2016
librbd: journal replay needs to support re-executing maintenance ops Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.