osd/PGLog: fix warning #8057
Merged
osd/PGLog: fix warning #8057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osd/PGLog.h: In member function 'virtual unsigned int PGLog::get_subsys() const':
osd/PGLog.h:39:28: warning: enumeral and non-enumeral type in conditional expression [-Wextra]
return prefix_provider ? prefix_provider->get_subsys() : ceph_subsys_osd;
^
Signed-off-by: Sage Weil <sage@redhat.com>
Can't silent these and we have no users left. They'll be removed soon, but I'm tired of sifting through all the warnings. Signed-off-by: Sage Weil <sage@redhat.com>
os/bluestore/KernelDevice.cc: In member function ‘virtual int KernelDevice::open(std::string)’:
os/bluestore/KernelDevice.cc:128:18: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
if (block_size != st.st_blksize) {
Signed-off-by: Sage Weil <sage@redhat.com>
|
lgtm |
liewegas
added a commit
that referenced
this pull request
Mar 15, 2016
osd/PGLog: fix warning Reviewed-by: Samuel Just <sjust@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
osd/PGLog.h: In member function 'virtual unsigned int PGLog::get_subsys() const':
osd/PGLog.h:39:28: warning: enumeral and non-enumeral type in conditional expression [-Wextra]
return prefix_provider ? prefix_provider->get_subsys() : ceph_subsys_osd;
^
Signed-off-by: Sage Weil sage@redhat.com