Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osd/PGLog: fix warning #8057

Merged
merged 3 commits into from Mar 15, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
24 changes: 10 additions & 14 deletions src/os/ObjectStore.h
Expand Up @@ -1467,8 +1467,8 @@ class ObjectStore {
// backends need not implement these at all.

/// Set an xattr on a collection
void collection_setattr(const coll_t& cid, const string& name, bufferlist& val)
__attribute__ ((deprecated)) {
void collection_setattr(const coll_t& cid, const string& name,
bufferlist& val) {
if (use_tbl) {
__u32 op = OP_COLL_SETATTR;
::encode(op, tbl);
Expand All @@ -1486,8 +1486,7 @@ class ObjectStore {
}

/// Remove an xattr from a collection
void collection_rmattr(const coll_t& cid, const string& name)
__attribute__ ((deprecated)) {
void collection_rmattr(const coll_t& cid, const string& name) {
if (use_tbl) {
__u32 op = OP_COLL_RMATTR;
::encode(op, tbl);
Expand All @@ -1502,8 +1501,7 @@ class ObjectStore {
data.ops++;
}
/// Set multiple xattrs on a collection
void collection_setattrs(const coll_t& cid, map<string,bufferptr>& aset)
__attribute__ ((deprecated)) {
void collection_setattrs(const coll_t& cid, map<string,bufferptr>& aset) {
if (use_tbl) {
__u32 op = OP_COLL_SETATTRS;
::encode(op, tbl);
Expand All @@ -1518,8 +1516,7 @@ class ObjectStore {
data.ops++;
}
/// Set multiple xattrs on a collection
void collection_setattrs(const coll_t& cid, map<string,bufferlist>& aset)
__attribute__ ((deprecated)) {
void collection_setattrs(const coll_t& cid, map<string,bufferlist>& aset) {
if (use_tbl) {
__u32 op = OP_COLL_SETATTRS;
::encode(op, tbl);
Expand Down Expand Up @@ -2208,8 +2205,7 @@ class ObjectStore {
* @returns 0 on success, negative error code on failure
*/
virtual int collection_getattr(const coll_t& cid, const char *name,
void *value, size_t size)
__attribute__ ((deprecated)) {
void *value, size_t size) {
return -EOPNOTSUPP;
}

Expand All @@ -2221,8 +2217,8 @@ class ObjectStore {
* @param bl buffer to receive value
* @returns 0 on success, negative error code on failure
*/
virtual int collection_getattr(const coll_t& cid, const char *name, bufferlist& bl)
__attribute__ ((deprecated)) {
virtual int collection_getattr(const coll_t& cid, const char *name,
bufferlist& bl) {
return -EOPNOTSUPP;
}

Expand All @@ -2233,8 +2229,8 @@ class ObjectStore {
* @param aset map of keys and buffers that contain the values
* @returns 0 on success, negative error code on failure
*/
virtual int collection_getattrs(const coll_t& cid, map<string,bufferptr> &aset)
__attribute__ ((deprecated)) {
virtual int collection_getattrs(const coll_t& cid,
map<string,bufferptr> &aset) {
return -EOPNOTSUPP;
}

Expand Down
2 changes: 1 addition & 1 deletion src/os/bluestore/KernelDevice.cc
Expand Up @@ -125,7 +125,7 @@ int KernelDevice::open(string p)
// require a read/modify/write if we write something smaller than
// it.
block_size = g_conf->bdev_block_size;
if (block_size != st.st_blksize) {
if (block_size != (unsigned)st.st_blksize) {
dout(1) << __func__ << " backing device/file reports st_blksize "
<< st.st_blksize << ", using bdev_block_size "
<< block_size << " anyway" << dendl;
Expand Down
3 changes: 2 additions & 1 deletion src/osd/PGLog.h
Expand Up @@ -36,7 +36,8 @@ struct PGLog : DoutPrefixProvider {
return prefix_provider ? prefix_provider->gen_prefix() : "";
}
unsigned get_subsys() const {
return prefix_provider ? prefix_provider->get_subsys() : ceph_subsys_osd;
return prefix_provider ? prefix_provider->get_subsys() :
(unsigned)ceph_subsys_osd;
}
CephContext *get_cct() const {
return cct;
Expand Down