New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
systemd: set up environment in rbdmap unit file #8222
Merged
Merged
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
#!/bin/sh | ||
# | ||
# Regression test for http://tracker.ceph.com/issues/14984 | ||
# | ||
# When the bug is present, starting the rbdmap service causes | ||
# a bogus log message to be emitted to the log because the RBDMAPFILE | ||
# environment variable is not set. | ||
# | ||
# When the bug is not present, starting the rbdmap service will emit | ||
# no log messages, because /etc/ceph/rbdmap does not contain any lines | ||
# that require processing. | ||
# | ||
set -ex | ||
|
||
which ceph-detect-init >/dev/null || exit 1 | ||
[ "$(ceph-detect-init)" = "systemd" ] || exit 0 | ||
|
||
echo "TEST: save timestamp for use later with journalctl --since" | ||
TIMESTAMP=$(date +%Y-%m-%d\ %H:%M:%S) | ||
|
||
echo "TEST: assert that rbdmap has not logged anything since boot" | ||
journalctl -b 0 -t rbdmap | grep 'rbdmap\[[[:digit:]]' && exit 1 | ||
journalctl -b 0 -t init-rbdmap | grep 'rbdmap\[[[:digit:]]' && exit 1 | ||
|
||
echo "TEST: restart the rbdmap.service" | ||
sudo systemctl restart rbdmap.service | ||
|
||
echo "TEST: ensure that /usr/bin/rbdmap runs to completion" | ||
until sudo systemctl status rbdmap.service | grep 'active (exited)' ; do | ||
sleep 0.5 | ||
done | ||
|
||
echo "TEST: assert that rbdmap has not logged anything since TIMESTAMP" | ||
journalctl --since "$TIMESTAMP" -t rbdmap | grep 'rbdmap\[[[:digit:]]' && exit 1 | ||
journalctl --since "$TIMESTAMP" -t init-rbdmap | grep 'rbdmap\[[[:digit:]]' && exit 1 | ||
|
||
exit 0 |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here we could add a packaging test that would check
which rbdmap
(just to verify that the shell script is packaged)