xio: provide dout_prefix for XioConnection #9444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -77,6 +77,14 @@ void print_ceph_msg(CephContext *cct, const char *tag, Message *m) | |||
| } | |||
| } | |||
|
|
|||
| #undef dout_prefix | |||
| #define dout_prefix _conn_prefix(_dout) | |||
| ostream& XioConnection::_conn_prefix(std::ostream *_dout) { | |||
There was a problem hiding this comment.
does this method need to have a leading _ in the name? I'd like to avoid that, if possible.
|
I only copied this format from AsyncMessneger i have no problem to remove the leading _ here |
|
@mattbenjamin Anything else needed here? do you us to change leading _ in the name? Thanks |
… and conn/sess 1. this prefix will be added for any log message from XioConnection (2. hence, remove info that is now redundeant in few existing log messages) Signed-off-by: Avner BenHanoch <avnerb@mellanox.com>
|
@mattbenjamin @avnerbh |
|
👍 |
|
@mattbenjamin , anything else needed here? |
|
@mattbenjamin can we progress with this issue? |
|
retest this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
provide dout_prefix for XioConnection with: from>>to, peer-type, and conn/sess
(2. hence, remove info that is now redundeant in few existing log messages)
Signed-off-by: Avner BenHanoch avnerb@mellanox.com