New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xio: provide dout_prefix for XioConnection #9444
Conversation
@@ -77,6 +77,14 @@ void print_ceph_msg(CephContext *cct, const char *tag, Message *m) | |||
} | |||
} | |||
|
|||
#undef dout_prefix | |||
#define dout_prefix _conn_prefix(_dout) | |||
ostream& XioConnection::_conn_prefix(std::ostream *_dout) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this method need to have a leading _ in the name? I'd like to avoid that, if possible.
I only copied this format from AsyncMessneger
i have no problem to remove the leading _ here |
@mattbenjamin Anything else needed here? do you us to change leading _ in the name? Thanks |
… and conn/sess 1. this prefix will be added for any log message from XioConnection (2. hence, remove info that is now redundeant in few existing log messages) Signed-off-by: Avner BenHanoch <avnerb@mellanox.com>
@mattbenjamin @avnerbh |
👍 |
@mattbenjamin , anything else needed here? |
@mattbenjamin can we progress with this issue? |
retest this please |
provide dout_prefix for XioConnection with: from>>to, peer-type, and conn/sess
(2. hence, remove info that is now redundeant in few existing log messages)
Signed-off-by: Avner BenHanoch avnerb@mellanox.com