Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add the necessary judgment #9694

Merged
merged 2 commits into from Aug 19, 2016
Merged

test: add the necessary judgment #9694

merged 2 commits into from Aug 19, 2016

Conversation

renhwztetecs
Copy link
Contributor

@renhwztetecs renhwztetecs commented Jun 14, 2016 •
edited

  1. test/librados: add ASSERT_EQ & ASSERT_NE judgment
  2. test/libcephfs: add the necessary judgment

Signed-off-by: huanwen ren ren.huanwen@zte.com.cn

@renhwztetecs
test/libcephfs: add the necessary judgment
180f38a 
add the necessary judgment in the access.cc

Signed-off-by: huanwen ren <ren.huanwen@zte.com.cn>
@renhwztetecs renhwztetecs force-pushed the renhw-wip-librados-iotest branch 3 times, most recently from 926e346 to 180f38a Compare June 14, 2016 15:11
test/librados: add ASSERT_EQ & ASSERT_NE judgment
6c67073 
Signed-off-by: huanwen ren <ren.huanwen@zte.com.cn>
@renhwztetecs renhwztetecs force-pushed the renhw-wip-librados-iotest branch 3 times, most recently from 7dd7797 to 7492955 Compare June 21, 2016 11:43
@yuriw
Copy link
Contributor

yuriw commented Jul 19, 2016 •
edited

@renhwztetecs this PR seems to be failing in "[ FAILED ] LibRadosIo.ReadTimeout" test
Run: http://pulpito.ceph.com/yuriw-2016-07-19_15:14:36-rados-wip-yuri-testing__2016_7_18-distro-basic-smithi/

jobs: 323179, 323216, 323239, 323243

One for example in http://qa-proxy.ceph.com/teuthology/yuriw-2016-07-19_15:14:36-rados-wip-yuri-testing__2016_7_18-distro-basic-smithi/323179/teuthology.log

2016-07-19T15:44:18.334 INFO:tasks.workunit.client.0.smithi019.stdout: api_io: /srv/autobuild-ceph/gitbuilder.git/build/rpmbuild/BUILD/ceph-11.0.0/src/test/librados/io.cc:57: Failure
2016-07-19T15:44:18.335 INFO:tasks.workunit.client.0.smithi019.stdout: api_io: Expected: (0) != (rados_connect(cluster)), actual: 0 vs 0
2016-07-19T15:44:18.335 INFO:tasks.workunit.client.0.smithi019.stdout: api_io: [ FAILED ] LibRadosIo.ReadTimeout (3165 ms)

jdurgin
jdurgin reviewed Jul 19, 2016
View reviewed changes
src/test/librados/io.cc
ASSERT_EQ(0, rados_conf_read_file(cluster, NULL));
ASSERT_EQ(0, rados_conf_parse_env(cluster, NULL));
ASSERT_EQ(0, rados_conf_set(cluster, "rados_osd_op_timeout", "0.00001")); // use any small value that will result in a timeout
ASSERT_NE(0, rados_connect(cluster));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should succeed - rados_osd_op_timeout only applies to OSD ops (like the read checked below), not the initial connection

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks
I missing, change it

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@renhwztetecs. seems we still have this change? see http://tracker.ceph.com/issues/17087

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed by #10806

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am sure I modified it，I don't know what happened
But thank you to fixup it

@renhwztetecs
Copy link
Contributor Author

Done

@jdurgin
Copy link
Member

jdurgin commented Jul 20, 2016

thanks, looks good

@renhwztetecs
Copy link
Contributor Author

@yuriw
help me testing
thank you

@jdurgin jdurgin added the core label Aug 16, 2016
@tchaikov
Copy link
Contributor

tested http://pulpito.ceph.com/kchai-2016-08-18_15:35:36-rados-wip-kefu-testing2---basic-mira/

all failures are known ones.

@tchaikov tchaikov merged commit 34a80e8 into ceph:master Aug 19, 2016
@renhwztetecs renhwztetecs deleted the renhw-wip-librados-iotest branch August 19, 2016 05:56
@renhwztetecs renhwztetecs restored the renhw-wip-librados-iotest branch August 22, 2016 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdurgin jdurgin

Labels
cleanup core needs-qa tests wip-kefu-testing
Projects
None yet
Milestone
No milestone
5 participants
@renhwztetecs @yuriw @jdurgin @tchaikov @liewegas