New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add the necessary judgment #9694
Conversation
add the necessary judgment in the access.cc Signed-off-by: huanwen ren <ren.huanwen@zte.com.cn>
926e346
to
180f38a
Compare
Signed-off-by: huanwen ren <ren.huanwen@zte.com.cn>
7dd7797
to
7492955
Compare
7492955
to
6c67073
Compare
@renhwztetecs this PR seems to be failing in "[ FAILED ] LibRadosIo.ReadTimeout" test jobs: 323179, 323216, 323239, 323243 One for example in http://qa-proxy.ceph.com/teuthology/yuriw-2016-07-19_15:14:36-rados-wip-yuri-testing__2016_7_18-distro-basic-smithi/323179/teuthology.log 2016-07-19T15:44:18.334 INFO:tasks.workunit.client.0.smithi019.stdout: api_io: /srv/autobuild-ceph/gitbuilder.git/build/rpmbuild/BUILD/ceph-11.0.0/src/test/librados/io.cc:57: Failure |
ASSERT_EQ(0, rados_conf_read_file(cluster, NULL)); | ||
ASSERT_EQ(0, rados_conf_parse_env(cluster, NULL)); | ||
ASSERT_EQ(0, rados_conf_set(cluster, "rados_osd_op_timeout", "0.00001")); // use any small value that will result in a timeout | ||
ASSERT_NE(0, rados_connect(cluster)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should succeed - rados_osd_op_timeout only applies to OSD ops (like the read checked below), not the initial connection
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
I missing, change it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@renhwztetecs. seems we still have this change? see http://tracker.ceph.com/issues/17087
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed by #10806
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am sure I modified it,I don't know what happened
But thank you to fixup it
6c67073
to
64e8248
Compare
Done |
thanks, looks good |
@yuriw |
64e8248
to
6c67073
Compare
tested http://pulpito.ceph.com/kchai-2016-08-18_15:35:36-rados-wip-kefu-testing2---basic-mira/ all failures are known ones. |
Signed-off-by: huanwen ren ren.huanwen@zte.com.cn