msg/async: harden error logic handle #9781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
passed http://pulpito.ceph.com/haomai-2016-06-21_12:24:39-rados-wip-haomai-testing-distro-basic-smithi/ one test issue (fix later) |
yuyuyu101
force-pushed
the
wip-epoll
branch
4 times, most recently
from
eab68c0
to
2f4b152
Compare
Signed-off-by: Haomai Wang <haomai@xsky.com>
The original logic is from ceph@ba140b5 I think it doesn't make sense in detail errno case. Signed-off-by: Haomai Wang <haomai@xsky.com>
It's rare happen in real env, because each socket has enough write buffer to store a little handshake info. Just harden the current codes Signed-off-by: Haomai Wang <haomai@xsky.com>
Partial revert 84b9088 Signed-off-by: Haomai Wang <haomai@xsky.com>
…own dq 1. ensure stop accepter before shutdown dispatcherqueue 2. ensure we don't generate new item after dispatcher queue shutdown Signed-off-by: Haomai Wang <haomai@xsky.com>
|
passed http://pulpito.ceph.com/haomai-2016-06-28_15:13:46-rados-wip-haomai-testing---basic-smithi vargind issue (rocksdb) |
|
@yuyuyu101 Haomai, it seems this pr introduces a compiling error, check: https://jenkins.ceph.com/job/ceph-pull-requests/8173/console |
|
@xiexingguo yes, it's false rebase |
|
@yuyuyu101 master is broken. mind taking a look? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr don't fix any existing bug. Only fill up the potential error handle leak.