Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

msg/async: add "queue_reset" argument #9992

Merged
merged 1 commit into from Jun 29, 2016
Merged

Conversation

yuyuyu101
Copy link
Member

Signed-off-by: Haomai Wang haomai@xsky.com

Signed-off-by: Haomai Wang <haomai@xsky.com>
@yuyuyu101
Copy link
Member Author

fix rebase conflicting introduced(#9781)

@xiexingguo
Copy link
Member

xiexingguo commented Jun 29, 2016

How about this(so we don't have to change the default behaviour of stop too much):

-  void stop(bool queue_reset) {
+  void stop(bool queue_reset = true) {
     lock.Lock();
     bool need_queue_reset = (state != STATE_CLOSED) && queue_reset;

@yuyuyu101
Copy link
Member Author

... there is no much difference since it's a internal interface. if possible we should be prefer avoid default argument value

@xiexingguo
Copy link
Member

Ok, suit yourself.

@tchaikov
Copy link
Contributor

lgtm.

@tchaikov tchaikov merged commit 3d5fa5e into ceph:master Jun 29, 2016
@yuyuyu101 yuyuyu101 deleted the wip-fix-rebase branch June 29, 2016 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants