rbd-mirror: gracefully handle being blacklisted #9970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dillaman could you please rebase when you have spare time |
|
@trociny rebase pushed |
trociny
pushed a commit
that referenced
this pull request
Jun 29, 2016
[DNM] rbd-mirror: gracefully handle being blacklisted #9970
| @@ -311,7 +356,7 @@ int Replayer::init() | |||
| // librados::Rados::conf_parse_argv | |||
| r = cct->_conf->parse_argv(m_args); | |||
There was a problem hiding this comment.
@dillaman Need to pass a copy of m_args, because parse_argv removes parsed items from the vector. You can see this running rbd_mirror.sh and observing that log and asok file names are not properly set for the remote context.
|
@dillaman compilation of test/rbd_mirror/image_replay.cc fails. See jenkins logs. |
|
@trociny updates pushed |
trociny
pushed a commit
that referenced
this pull request
Jun 30, 2016
[DNM] rbd-mirror: gracefully handle being blacklisted #9970
|
@dillaman please rebase |
trociny
pushed a commit
that referenced
this pull request
Jul 3, 2016
[DNM] rbd-mirror: gracefully handle being blacklisted #9970 Conflicts: src/test/rbd_mirror/image_replay.cc
trociny
pushed a commit
that referenced
this pull request
Jul 6, 2016
[DNM] rbd-mirror: gracefully handle being blacklisted #9970 Conflicts: src/test/rbd_mirror/image_replay.cc
added 4 commits
July 6, 2016 11:36
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Fixes: http://tracker.ceph.com/issues/16349 Signed-off-by: Jason Dillaman <dillaman@redhat.com>
dillaman
changed the title
|
@trociny rebased and pushed |
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.