-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rbd-mirror: gracefully handle being blacklisted #9970
Conversation
@dillaman could you please rebase when you have spare time |
@trociny rebase pushed |
[DNM] rbd-mirror: gracefully handle being blacklisted #9970
@@ -311,7 +356,7 @@ int Replayer::init() | |||
// librados::Rados::conf_parse_argv | |||
r = cct->_conf->parse_argv(m_args); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dillaman Need to pass a copy of m_args, because parse_argv removes parsed items from the vector. You can see this running rbd_mirror.sh and observing that log and asok file names are not properly set for the remote context.
@dillaman compilation of test/rbd_mirror/image_replay.cc fails. See jenkins logs. |
@trociny updates pushed |
[DNM] rbd-mirror: gracefully handle being blacklisted #9970
@dillaman please rebase |
[DNM] rbd-mirror: gracefully handle being blacklisted #9970 Conflicts: src/test/rbd_mirror/image_replay.cc
[DNM] rbd-mirror: gracefully handle being blacklisted #9970 Conflicts: src/test/rbd_mirror/image_replay.cc
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Fixes: http://tracker.ceph.com/issues/16349 Signed-off-by: Jason Dillaman <dillaman@redhat.com>
@trociny rebased and pushed |
lgtm |
No description provided.