criu: fix a fatal failure if nft doesn't work #2403
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On some systems, nft binary might not be installed, or some kernel options might be unconfigured, resulting in something like this: sudo unshare -n nft create table inet CRIU Error: Could not process rule: Operation not supported create table inet CRIU ^^^^^^^^^^^^^^^^^^^^^^^ This is similar to what kerndat_has_nftables_concat() does, and if the outcome is the same, it returns an error to kerndat_init(), and an error from kerndat_init() is considered fatal. Let's relax the check, returning mere "feature not working" instead of a fatal error. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
kolyshkin
added a commit
to kolyshkin/runc
that referenced
this pull request
May 10, 2024
Currently, actuated runners have kernel 6.1.90 with CONFIG_NF_TABLES_INET not set. This uncovers criu bug [1] thus making c/r impossible to work. Let's not install criu binary for now, effectively disabling c/r tests. [1] checkpoint-restore/criu#2403 Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
This was referenced May 10, 2024
|
Applied. Thanks! |
|
LGTM. Closing as the patch has been applied to the criu-dev branch. |
|
The patch looks good. But it seems that (I mean the only consequence of it set is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On some systems, nft binary might not be installed, or some kernel options might be unconfigured, resulting in something like this:
This is similar to what
kerndat_has_nftables_concat()does, and if the outcome is the same, it returns an error tokerndat_init(), and an error fromkerndat_init()is considered fatal.Let's relax the check, returning mere "feature not working" instead of a fatal error.
This was discovered while running criu CI on ARM via actuated ci env generously provided by @alexellis. Currently it runs kernel 6.1.90 with the following config:
I guess that missing
CONFIG_NF_TABLES_INETis the source of the issue.Adding this patch on top of current criu-dev fixes all failures of runc c/r tests (see e.g. https://github.com/opencontainers/runc/actions/runs/9024939764/job/24799738301).
How it failed before the fix
Failed run (using criu_3.19-2_arm64.deb from https://download.opensuse.org/repositories/devel:/tools:/criu/xUbuntu_22.04) looks like this (from https://github.com/opencontainers/runc/actions/runs/9023994162/job/24796971230):
(failures in runc integration tests are similar).