Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new TkAlMap version (xy inversion fix) #2

Merged
merged 1 commit into from Feb 23, 2022

Conversation

SenneVanPutte
Copy link
Contributor

xy coordinates where flipped to be equivalent everywhere

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @SenneVanPutte for branch master.

@smuzaffar, @yuanchao, @malbouis, @iarspider, @cmsbuild, @tvami, @ddaina, @francescobrivio can you please review it and eventually sign? Thanks.
@mmusich, @adewit, @tocheng, @tlampen this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.
cms-bot commands are listed here

@tvami
Copy link

tvami commented Nov 30, 2021

@cmsbuild , please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8e38af/20864/summary.html
COMMIT: 209204c
CMSSW: CMSSW_12_2_X_2021-11-29-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-data/Alignment-OfflineValidation/2/20864/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 41
  • DQMHistoTests: Total histograms compared: 3042214
  • DQMHistoTests: Total failures: 5
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3042186
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 40 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 175 log files, 37 edm output root files, 41 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link

tvami commented Nov 30, 2021

+alca

@smuzaffar
Copy link

+externals

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@smuzaffar
Copy link

please test
lets refresh the test results for 12.3.X
FYI @qliphy , @perrotta , this looks ready to go in

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8e38af/22605/summary.html
COMMIT: 209204c
CMSSW: CMSSW_12_3_X_2022-02-22-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-data/Alignment-OfflineValidation/2/22605/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8e38af/22605/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8e38af/22605/git-merge-result

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 3 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 4001143
  • DQMHistoTests: Total failures: 8
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4001113
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 204 log files, 45 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link

@SenneVanPutte , in order not to sign it blindly, could you please add to the PR description two lines of explanation, or a link to a presentation (at an AlCa meeting?), or anything else that can explain what you are doing and why?
@tvami your signature was done in last November: is this cms-data change still needed now in February?

@tvami
Copy link

tvami commented Feb 23, 2022

I think it's usueful to have it, but not a showstopper not to have it, i.e. I think we can merge it in 12_3_X

@perrotta
Copy link

I think it's usueful to have it, but not a showstopper not to have it, i.e. I think we can merge it in 12_3_X

Thank you @tvami
And, out of curiosity: what is it?

@mmusich
Copy link

mmusich commented Feb 23, 2022

It's needed to make TrackerMap plots formatted as in the alignment paper TRK-20-001 e.g.
Screenshot_20220223-213235_Samsung Notes

@perrotta
Copy link

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants