Update GBL (and move to git instead of svn) #7638

iarspider · 2022-02-21T11:28:28Z

No description provided.

cmsbuild · 2022-02-21T11:28:50Z

A new Pull Request was created by @iarspider for branch IB/CMSSW_12_3_X/master.

@cmsbuild, @smuzaffar, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @qliphy you are the release manager for this.
cms-bot commands are listed here

iarspider · 2022-02-21T11:29:02Z

please test

cmsbuild · 2022-02-21T12:06:10Z

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-791b5d/22534/summary.html
COMMIT: d3df4a1
CMSSW: CMSSW_12_3_X_2022-02-20-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/7638/22534/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

@slava77 remove mkFit external #7528

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-791b5d/22534/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-791b5d/22534/git-merge-result

Build

I found compilation error when building:

>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_3_X_2022-02-20-2300/src/Alignment/MillePedeAlignmentAlgorithm/plugins/MomentumDependentPedeLabeler.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_3_X_2022-02-20-2300/src/Alignment/MillePedeAlignmentAlgorithm/plugins/PedeLabeler.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_3_X_2022-02-20-2300/src/Alignment/MillePedeAlignmentAlgorithm/plugins/RunRangeDependentPedeLabeler.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_3_X_2022-02-20-2300/src/Alignment/MillePedeAlignmentAlgorithm/plugins/ZMuMuMassConstraintParameterFinder.cc
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_3_X_2022-02-20-2300/src/Alignment/MillePedeAlignmentAlgorithm/plugins/MillePedeAlignmentAlgorithm.cc: In member function 'std::pair MillePedeAlignmentAlgorithm::addReferenceTrajectory(const edm::EventSetup&, const AlignmentAlgorithmBase::EventInfo&, const value_type&)':
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_3_X_2022-02-20-2300/src/Alignment/MillePedeAlignmentAlgorithm/plugins/MillePedeAlignmentAlgorithm.cc:517:24: error: 'class gbl::GblPoint' has no member named 'hasMeasurement'; did you mean 'addMeasurement'?
  517 |           if (itPoint->hasMeasurement() >= 1)
      |                        ^~~~~~~~~~~~~~
      |                        addMeasurement
gmake: *** [tmp/slc7_amd64_gcc10/src/Alignment/MillePedeAlignmentAlgorithm/plugins/AlignmentMillePedeAlignmentAlgorithmAuto/MillePedeAlignmentAlgorithm.cc.o] Error 1
>> Building  edm plugin tmp/slc7_amd64_gcc10/src/Alignment/MillePedeAlignmentAlgorithm/plugins/AlignmentMillePedeAlignmentAlgorithmAuto/libAlignmentMillePedeAlignmentAlgorithmAuto.so

iarspider · 2022-02-21T13:38:15Z

please test with cms-sw/cmssw#37008

cmsbuild · 2022-02-21T19:11:20Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-791b5d/22538/summary.html
COMMIT: d3df4a1
CMSSW: CMSSW_12_3_X_2022-02-20-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/7638/22538/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-791b5d/22538/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-791b5d/22538/git-merge-result

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 120 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3965143
DQMHistoTests: Total failures: 59
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3965062
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
Checked 204 log files, 45 edm output root files, 49 DQM output files
TriggerResults: no differences found

smuzaffar · 2022-02-21T22:58:48Z

please test

cmsbuild · 2022-02-21T22:59:24Z

New categories assigned: generators

@mkirsano,@alberto-sanchez,@SiewYan,@GurpreetSinghChahal,@Saptaparna you have been requested to review this Pull request/Issue and eventually sign? Thanks

smuzaffar · 2022-02-22T10:55:34Z

test parameters:

pull_requests = MillePedeAlignmentAlgorithm: update for new GBL version cmssw#37008

smuzaffar · 2022-02-22T10:55:48Z

please test

smuzaffar · 2022-02-22T18:00:13Z

+externals

cmsbuild · 2022-02-22T18:00:36Z

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_12_3_X/master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

cmsbuild · 2022-02-22T18:22:19Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-791b5d/22573/summary.html
COMMIT: d3df4a1
CMSSW: CMSSW_12_3_X_2022-02-21-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/7638/22573/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

@trackreco patch-around immintrin.h for non-x86 case in MkFit cmssw#37014
@bsunanda Run3-sim109C Clean the analyzers in SimG4CMS/CherenkovAnalysis/plugins cmssw#37003
@bsunanda Run3-TB68 Clean up the analyzers of HCAL TB applications in SimG4CMS/HcalTestBeam/plugins cmssw#37002
@jeongeun Clean up redundant edm ParameterSet existAs or exist in RecoTracker/{TkSeedGenerator} cmssw#36989
@cms-tsg-storm HLT menu development for 12_3_X cmssw#37006
@alejands Create new ECAL DQM GpuTask to monitor and compare CPU and GPU generated ECAL RECO objects cmssw#36742

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-791b5d/22573/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-791b5d/22573/git-merge-result

Comparison Summary

Summary:

No significant changes to the logs found
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3965137
DQMHistoTests: Total failures: 10974
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3954141
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 10144.572 KiB( 48 files compared)
DQMHistoSizes: changed ( 11634.0,... ): 1690.762 KiB HLT/Muon
Checked 204 log files, 45 edm output root files, 49 DQM output files
TriggerResults: found differences in 7 / 48 workflows

qliphy · 2022-02-23T00:39:13Z

+1

iarspider added 2 commits February 21, 2022 11:15

Update GBL (and move to git instead of svn)

ba26076

Fix source path

d3df4a1

cmsbuild added externals-pending orp-pending pending-signatures tests-pending labels Feb 21, 2022

iarspider requested a review from smuzaffar February 21, 2022 11:29

cmsbuild added tests-started tests-rejected and removed tests-pending tests-started labels Feb 21, 2022

iarspider mentioned this pull request Feb 21, 2022

MillePedeAlignmentAlgorithm: update for new GBL version cms-sw/cmssw#37008

Merged

cmsbuild added requires-external tests-started and removed tests-rejected labels Feb 21, 2022

cmsbuild added tests-approved and removed tests-started labels Feb 21, 2022

cmsbuild removed the requires-external label Feb 21, 2022

cmsbuild added generators-pending tests-started and removed tests-approved labels Feb 21, 2022

cmsbuild added requires-external and removed generators-pending labels Feb 22, 2022

smuzaffar approved these changes Feb 22, 2022

View reviewed changes

cmsbuild added externals-approved fully-signed and removed externals-pending pending-signatures labels Feb 22, 2022

cmsbuild added tests-approved and removed tests-started labels Feb 22, 2022

cmsbuild added orp-approved and removed orp-pending labels Feb 23, 2022

cmsbuild merged commit e09d7fc into IB/CMSSW_12_3_X/master Feb 23, 2022

iarspider deleted the update-gbl branch February 23, 2022 07:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update GBL (and move to git instead of svn) #7638

Update GBL (and move to git instead of svn) #7638

iarspider commented Feb 21, 2022

cmsbuild commented Feb 21, 2022

iarspider commented Feb 21, 2022

cmsbuild commented Feb 21, 2022

iarspider commented Feb 21, 2022

cmsbuild commented Feb 21, 2022

smuzaffar commented Feb 21, 2022

cmsbuild commented Feb 21, 2022

smuzaffar commented Feb 22, 2022

smuzaffar commented Feb 22, 2022

smuzaffar commented Feb 22, 2022

cmsbuild commented Feb 22, 2022

cmsbuild commented Feb 22, 2022

qliphy commented Feb 23, 2022

Update GBL (and move to git instead of svn) #7638

Update GBL (and move to git instead of svn) #7638

Conversation

iarspider commented Feb 21, 2022

cmsbuild commented Feb 21, 2022

iarspider commented Feb 21, 2022

cmsbuild commented Feb 21, 2022

Build

iarspider commented Feb 21, 2022

cmsbuild commented Feb 21, 2022

Comparison Summary

smuzaffar commented Feb 21, 2022

cmsbuild commented Feb 21, 2022

smuzaffar commented Feb 22, 2022

smuzaffar commented Feb 22, 2022

smuzaffar commented Feb 22, 2022

cmsbuild commented Feb 22, 2022

cmsbuild commented Feb 22, 2022

Comparison Summary

qliphy commented Feb 23, 2022