Updated files for the v1_1_0 menu for Run 3 (and minor fix for v1_0_0)

[elfontan]

An updated full set of xml files for the L1 emulation of prescales and masks coherent with the updated v1_1_0 L1 menu for Run 3 is provided, targeting CMSSW_12_4_0.
The current version of the updated L1 Menu can be found in [1]: L1Menu_Collisions2022_v1_1_0.
NOTE: the current setup of the L1 prescales is still not updated according to the needs for the start of Run 3 given some ongoing discussions to finalize them. For now, the PS table is pretty much the copy of the last 2018 PS table. The update of these files is needed in order to provide a structure of the PS and masks tables fully compatible with the updated menu, so that it is usable for development purposes.

A minor update of the files from the previous PR #9) is also included.

In the context of the trigger studies for the preparation of the Run 3 menu (L1+HLT), we faced an issue related to the emulation of the L1 prescales. Two different issues were found out:

• format of the PS table (some documentation and a recipe can be found here);
• usage of the fractional PS (Update to L1 prescale code following move to fractional prescales cms-sw/cmssw#37046).

Once that these new files are available here, we will follow-up with the draft PR to update the PrescalesVetosFract_cff.py file: cms-sw/cmssw#38250.

Related github issue for the backport to CMSSW_12_4_0 is #12.

[1]
https://github.com/cms-l1-dpg/L1MenuRun3/tree/master/development/L1Menu_Collisions2022_v1_1_0

[cmsbuild]

A new Pull Request was created by @elfontan (Elisa Fontanesi) for branch master.

@smuzaffar, @epalencia, @aandvalenzuela, @iarspider, @cmsbuild, @rekovic, @cecilecaillol can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.
cms-bot commands are listed here

[epalencia]

please test

[cmsbuild]

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-01afcf/25287/summary.html
COMMIT: 5bce392
CMSSW: CMSSW_12_5_X_2022-06-05-0000/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-data/L1Trigger-L1TGlobal/11/25287/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @cms-sw [XROOTD] Build client only cms-sw/cmsdist#7909
• @gartung Update to HEAD of libunwind master. Patch is no longer needed. cms-sw/cmsdist#7910

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-01afcf/25287/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-01afcf/25287/git-merge-result

Unit Tests

I found errors in the following unit tests:

---> test TestGeneratorInterfacePythia8InterfaceCompareExternalStreams had ERRORS
---> test testGeneratorInterfacePythia8InterfaceTP had ERRORS

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3651603
• DQMHistoTests: Total failures: 8
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3651573
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 208 log files, 45 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[cmsbuild]

Pull request #11 was updated.

[epalencia]

Please test

[elfontan]

Hello @smuzaffar,
do you understand the failure above during the test? Any hint about it?
Thanks a lot in advance,
--Elisa

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-01afcf/25361/summary.html
COMMIT: 2fe3bc8
CMSSW: CMSSW_12_5_X_2022-06-08-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-data/L1Trigger-L1TGlobal/11/25361/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3652078
• DQMHistoTests: Total failures: 14
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3652042
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 208 log files, 45 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[smuzaffar]

Hello @smuzaffar, do you understand the failure above during the test? Any hint about it? Thanks a lot in advance, --Elisa

I guess tests were running on a busy machine as I see error message

----- Begin Fatal Exception 06-Jun-2022 01:12:18 CEST-----------------------
An exception of category 'ExternalFailed' occurred while
   [0] Processing global begin LuminosityBlock run: 1 luminosityBlock: 1
   [1] Calling method for module ExternalGeneratorFilter/'toTest'
Exception Message:
failed waiting for external process 22444_0. Timed out after 300 seconds.
----- End Fatal Exception -------------------------------------------------

anyway, tests are running fine now. By the way, is there any cmssw PR to test these data file changes?

[elfontan]

Thank you @smuzaffar!
The related cmssw PR is cms-sw/cmssw#38250.
However, as mentioned in the previous similar PR, these are the "default files" to be used in some config files, that are not used in any standard workflow.
They would be used for the re-emulation of the L1 prescales and masks when applying a dedicated recipe that you can find e.g. here. The specific script that calls those two configuration files containing the new files is hackConditions_cff.py.

[smuzaffar]

+externals

[cecilecaillol]

+l1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[elfontan]

Hello,
I just moved cms-sw/cmssw#38250 from "Draft" to "Ready for review" and I am going to prepare the related backport. Would it be possible to proceed with the integration of these files and to deal with the related open issue #12 for the backport?

Thanks a lot in advance,
--Elisa

[perrotta]

+1

• See New set of files coherent with the new v1_1_0 L1Menu cms-sw/cmssw#38250 (comment)