New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update of the sqlite DB for more complete L1 O2O unit tests #2
base: main
Are you sure you want to change the base?
Conversation
…artially pre-o2o'ed L1 system
A new Pull Request was created by @panoskatsoulis (Panos) for branch main. @smuzaffar, @epalencia, @aandvalenzuela, @iarspider, @cmsbuild, @rekovic, @cecilecaillol can you please review it and eventually sign? Thanks. |
@cmsbuild , please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b25bf9/25169/summary.html The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Comparison SummarySummary:
|
assign db |
+db |
New categories assigned: db @ggovi,@francescobrivio,@malbouis,@tvami you have been requested to review this Pull request/Issue and eventually sign? Thanks |
@cecilecaillol or @epalencia |
+l1 |
+externals |
@smuzaffar I read from cms-sw/cmssw#37861 (comment) that: the file in https://github.com/cms-data/L1TriggerConfig-L1TConfigProducers is meant to be updated too for better future testing. So it should be good to go. @cecilecaillol @panoskatsoulis Please confirm. |
I can confirm that's the plan |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b25bf9/35771/summary.html The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: You can see more details here: Comparison SummarySummary:
|
The need for this updated file has been described in PR cms-sw/cmssw#37861 .
Extra
PAYLOAD
s andIOV
s have been added to the existing sqlite file to account for cases where part of the L1 keys have already been o2o'ed.Tested this with the following steps:
Step 1)
Ran the 2 new L1O2O unit tests on vanilla 12_3_2 (where the issue first appear) with the failures below.
Step 2)
Cherry picked the commit from the PR mentioned above and fixed the failures.