Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Geant4 compound materials construction #59

Merged
merged 1 commit into from Apr 15, 2022

Conversation

civanch
Copy link
Contributor

@civanch civanch commented Apr 14, 2022

This PR provide fix of construction of CMS compound materials from G4Elements and G4Materials, when Geant4 11.0.1 is used. It is essential for Run2 but also useful for Run3 and Phase-2 WFs. This fix has nothing to do with VecGeom.

@cmsbuild
Copy link

A new Pull Request was created by @civanch (Vladimir Ivantchenko) for branch cms/v11.0.1.

@cmsbuild, @smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @qliphy you are the release manager for this.
cms-bot commands are listed here

@smuzaffar
Copy link
Contributor

please test for CMSSW_12_4_GEANT4_X

@cmsbuild
Copy link

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a818cf/23931/summary.html
COMMIT: 7a2b826
CMSSW: CMSSW_12_4_GEANT4_X_2022-04-12-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-externals/geant4/59/23931/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a818cf/23931/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a818cf/23931/git-merge-result

Unit Tests

I found errors in the following unit tests:

---> test testMakeTrackValidationPlots had ERRORS

Comparison Summary

Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 63994 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3593033
  • DQMHistoTests: Total failures: 430847
  • DQMHistoTests: Total nulls: 298
  • DQMHistoTests: Total successes: 3161866
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1.6870000000000003 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 10224.0 ): -0.596 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 11834.0 ): 4.896 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 250202.181 ): 0.006 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 25202.0 ): -0.715 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 7.3 ): -0.367 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 8.0 ): -1.537 KiB SiStrip/MechanicalView
  • Checked 200 log files, 45 edm output root files, 48 DQM output files
  • TriggerResults: found differences in 14 / 47 workflows

@civanch
Copy link
Contributor Author

civanch commented Apr 18, 2022

@smuzaffar , thanks for the merge, all tests in GEANT4 branch are fine, no warning anymore both in Run2 and Run3 WFs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants