New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed Geant4 compound materials construction #59
Conversation
A new Pull Request was created by @civanch (Vladimir Ivantchenko) for branch cms/v11.0.1. @cmsbuild, @smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks. |
please test for CMSSW_12_4_GEANT4_X |
-1 Failed Tests: UnitTests The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Unit TestsI found errors in the following unit tests: ---> test testMakeTrackValidationPlots had ERRORS Comparison SummarySummary:
|
@smuzaffar , thanks for the merge, all tests in GEANT4 branch are fine, no warning anymore both in Run2 and Run3 WFs. |
This PR provide fix of construction of CMS compound materials from G4Elements and G4Materials, when Geant4 11.0.1 is used. It is essential for Run2 but also useful for Run3 and Phase-2 WFs. This fix has nothing to do with VecGeom.