starlight tool file updated #2049
Conversation
|
A new Pull Request was created by @KiSooLee for branch IB/CMSSW_8_0_X/stable. @cmsbuild, @smuzaffar, @Degano, @iahmad-khan, @davidlange6 can you please review it and eventually sign? Thanks. |
| @@ -0,0 +1,35 @@ | |||
| Release: 1%{?dist} | |||
There was a problem hiding this comment.
This definition is unused, it should instead read:
### RPM external starlight r193 (using the current release on cms-externals repository)
|
Also please test this following this guide: https://twiki.cern.ch/twiki/bin/view/CMS/SDTHowToBuildExternalTools |
|
Thank you for the guide |
|
Pull request #2049 was updated. |
|
Pull request #2049 was updated. |
|
+1 |
| @@ -0,0 +1,19 @@ | |||
| ### RPM external starlight r193 | |||
| Requires: clhep gfortran | |||
There was a problem hiding this comment.
Remove gfortran, there are no separate external for it (it comes from GCC package).
|
Pull request #2049 was updated. |
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
|
Pull request #2049 was updated. |
|
-1 \+ for x in . + i=/build/cmsbuild/jenkins-workarea/workspace/cmsdist-test-pr/testBuildDir/slc6_amd64_gcc493/./etc/profile.d/init.sh + '[' -f /build/cmsbuild/jenkins-workarea/workspace/cmsdist-test-pr/testBuildDir/slc6_amd64_gcc493/./etc/profile.d/init.sh ']' + ./configure --prefix=/build/cmsbuild/jenkins-workarea/workspace/cmsdist-test-pr/testBuildDir/tmp/BUILDROOT/1740ab4262d33a988dacc0fe36d6e55e/opt/cmssw/slc6_amd64_gcc493/external/starlight-toolfile/1.0 /build/cmsbuild/jenkins-workarea/workspace/cmsdist-test-pr/testBuildDir/tmp/rpm-tmp.ui1XbD: line 26: ./configure: No such file or directory error: Bad exit status from /build/cmsbuild/jenkins-workarea/workspace/cmsdist-test-pr/testBuildDir/tmp/rpm-tmp.ui1XbD (%build) RPM build errors: Bad exit status from /build/cmsbuild/jenkins-workarea/workspace/cmsdist-test-pr/testBuildDir/tmp/rpm-tmp.ui1XbD (%build) you can see the results of the tests here: |
|
@KiSooLee could you use my |
|
Yes the only difference was %build. |
|
Nope, there was more differences (library name, RPM sections, whitespace added were required by RPM, etc). |
|
That file is different from now I'm try to local test. |
|
starlight-toolfile.spec file is updated but starlight.spec file also need to be modified. |
|
Pull request #2049 was updated. |
|
@mkirsano could you please help here? It looks like this PR is going on since a long time... |
|
OK 28/01/16 11:29, Roberto Covarelli пишет:
|
|
Visual review of |
|
Hi David |
|
Ir has your final changes? |
|
yes |
|
Will try to build and review locally this evening ir over the weekend. |
|
Yes, I have build starlight package locally successfully. |
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
|
@KiSooLee The tests ran fine and we'll discuss this PR during the next ORP meeting (02/02/2016), meanwhile, unfortunately, cmssw-tool-conf has been modified, thus making this PR un-mergeable due to conflicts. Could you please rebase it? |
|
#2114 is identical to this one. |
cmssw-tool-conf.spec issue is resolved