new external starlight added

[smuzaffar]

same as #2049 with updated tag/hash of starlight

[smuzaffar]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/cmsdist-test-pr/83/console

[cmsbuild]

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_8_0_X/stable.

@cmsbuild, @smuzaffar, @Degano, @iahmad-khan, @davidlange6 can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

[davidlt]

Remove this line, there is no such file.

a/slc6_amd64_gcc493/external/starlight/r193-cms/lib
a/slc6_amd64_gcc493/external/starlight/r193-cms/lib/libStarlib.so
a/slc6_amd64_gcc493/external/starlight/r193-cms/lib/archive
a/slc6_amd64_gcc493/external/starlight/r193-cms/lib/archive/libStarlib.a

Other than that, LGTM.

[cmsbuild]

+1
Tested at: 7d23c85
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2114/83/summary.html

[smuzaffar]

merge
looks good

[smuzaffar]

@KiSooLee , starlight does not build with gcc 5.3.0. this is breaking gcc530 IBs.

In file included from /build/build/muz/sl1/BUILD/slc6_amd64_gcc530/external/starlight/r193/starlight-r193/src/randomgenerator.cpp:39:0:
/build/build/muz/sl1/slc6_amd64_gcc530/external/clhep/2.2.0.4-ikhhed/include/CLHEP/Random/Randomize.h:70:18: error: 'CLHEP::HepRandomGenActive' defined but not used [-Werror=unused-variable]
 static const int HepRandomGenActive = HepRandom::createInstance();
                  ^
cc1plus: all warnings being treated as errors

[davidlt]

I will take care of this, there is not much be done done (CXXFLAGS = -Wno-error=unused-variable).

[davidlt]

Solved.

[smuzaffar]

Thanks @davidlt, but I mistakenly merged it. This still needs to be discussed in ORP. So I am removing it from cmssw-tool-conf

[davidlt]

I wouldn't remove it. It does not affect CMSSW in any way. Wait for the decision in ORP.

[smuzaffar]

too late, already done :-)