Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protobuf update #2882

Merged
merged 2 commits into from Mar 6, 2017
Merged

Conversation

davidlange6
Copy link
Contributor

update protobuf version to 3.2.0 (I believe I followed the needed changes for aarch64 and ppc64le, but untested)

@davidlange6
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18152/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2017

A new Pull Request was created by @davidlange6 (David Lange) for branch IB/CMSSW_9_1_X/gcc530.

@cmsbuild, @smuzaffar, @iahmad-khan, @davidlange6 can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2017

-1

Tested at: 20a239b

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2882/18152/summary.html

I found follow errors while testing this PR

Failed tests: Build

  • Build:

I found an error when building:

>> Compiling  /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_1_X_2017-03-05-2300/src/DQMServices/Core/src/ROOTFilePB.pb.cc 
Entering library rule at CalibMuon/RPCCalibration
>> Compiling  /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_1_X_2017-03-05-2300/src/DQMServices/Core/src/MonitorElement.cc 
>> Compiling  /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_1_X_2017-03-05-2300/src/DQMServices/Core/src/QStatisticalTests.cc 
In file included from /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_1_X_2017-03-05-2300/src/DQMServices/Core/src/ROOTFilePB.pb.cc:5:0:
/build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_1_X_2017-03-05-2300/src/DQMServices/Core/src/ROOTFilePB.pb.h:17:2: error: #error This file was generated by an older version of protoc which is
 #error This file was generated by an older version of protoc which is
  ^
/build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_1_X_2017-03-05-2300/src/DQMServices/Core/src/ROOTFilePB.pb.h:18:2: error: #error incompatible with your Protocol Buffer headers. Please
 #error incompatible with your Protocol Buffer headers.  Please
  ^


@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2017

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

@davidlange6
Copy link
Contributor Author

Seems the test failures are a limitation of our testing procedure. I'll put this in revel unless there are reasons not to?

@davidlange6
Copy link
Contributor Author

Revel --> devel

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2017

The tests are being triggered in jenkins.
Using cmssw from cms-sw/cmssw#17798
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18167/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2017

Comparison job queued.

@smuzaffar smuzaffar merged commit 512f831 into cms-sw:IB/CMSSW_9_1_X/gcc530 Mar 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants