Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regenerate DQMServices/Core/src/ROOTFilePB.pb files for ptotocol buffer 3.2.0 #17798

Merged
merged 1 commit into from Mar 6, 2017
Merged

Regenerate DQMServices/Core/src/ROOTFilePB.pb files for ptotocol buffer 3.2.0 #17798

merged 1 commit into from Mar 6, 2017

Conversation

smuzaffar
Copy link
Contributor

Regenerated using

cmsenv
git cms-addpkg DQMServices/Core
cd $CMSSW_BASE/src
protoc --cpp_out=. DQMServices/Core/src/ROOTFilePB.proto

@cmsbuild cmsbuild added this to the Next CMSSW_9_1_X milestone Mar 6, 2017
@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2017

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

DQMServices/Core

@cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@barvic this is something you requested to watch as well.
@Muzaffar, @davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@smuzaffar
Copy link
Contributor Author

please test with cms-sw/cmsdist#2882

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2017 •
edited

The tests are being triggered in jenkins.
Using externals from cms-sw/cmsdist#2882
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18167/console

@cmsbuild cmsbuild mentioned this pull request Mar 6, 2017
Merged
@smuzaffar smuzaffar mentioned this pull request Mar 6, 2017
Merged
@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2017

+1
Tested at: 41a5303
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17798/18167/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17798/18167/summary.html

@smuzaffar smuzaffar merged commit 79af08b into cms-sw:master Mar 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available dqm-pending orp-pending pending-signatures requires-external tests-approved
Projects
None yet
Milestone
CMSSW_9_1_X
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@smuzaffar @cmsbuild