Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update sherpa to 2.2.4 #3405

Merged
merged 1 commit into from Sep 15, 2017
Merged

update sherpa to 2.2.4 #3405

merged 1 commit into from Sep 15, 2017

Conversation

smuzaffar
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_9_4_X/gcc630.

@cmsbuild, @smuzaffar, @mrodozov can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 12, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22901/console

@cmsbuild
Copy link
Contributor

-1

Tested at: 9e8358a

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3405/22901/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

  • Unit Tests:

I found errors in the following unit tests:

---> test condTestRegression had ERRORS

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3405/22901/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2642440
  • DQMHistoTests: Total failures: 20602
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2621649
  • DQMHistoTests: Total skipped: 189
  • DQMHistoTests: Total Missing objects: 0
  • Checked 107 log files, 14 edm output root files, 26 DQM output files

@pmillet
Copy link
Contributor

pmillet commented Sep 13, 2017

@smuzaffar As far as i can tell the error does not seem to be related to sherpa. What do you think?

@smuzaffar
Copy link
Contributor Author

@pmillet , yes error does not relate to this PR but we need to re-run the tests based on a newer IB CMSSW_9_4_X_2017-09-13-0100 which is not yet ready. I will start the tests once its available

@smuzaffar
Copy link
Contributor Author

please test
CMSSW_9_4_X_2017-09-13-0100 IB is ready for PR testing

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 13, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22937/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@smuzaffar
Copy link
Contributor Author

+externals
@davidlange6 , any objection including it for 94X. It is also requested for 93X along with openmpi change (https://github.com/cms-sw/cmsdist/pull/3367/files ) which were tested in 93X DEVEL IBs.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_9_4_X/gcc630 IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3405/22937/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2646524
  • DQMHistoTests: Total failures: 213
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2646122
  • DQMHistoTests: Total skipped: 189
  • DQMHistoTests: Total Missing objects: 0
  • Checked 107 log files, 14 edm output root files, 26 DQM output files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants