bugfix for sherpa compiled with openmpi support #20401

pmillet · 2017-09-06T14:10:35Z

No description provided.

cmsbuild · 2017-09-06T14:11:04Z

The code-checks are being triggered in jenkins.

cmsbuild · 2017-09-06T14:11:05Z

A new Pull Request was created by @pmillet for master.

It involves the following packages:

GeneratorInterface/SherpaInterface

@cmsbuild, @efeyazgan, @perrozzi, @thuer, @govoni can you please review it and eventually sign? Thanks.
@alberto-sanchez, @agrohsje, @mkirsano, @thuer this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

cmsbuild · 2017-09-06T14:13:21Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20401/525

Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/code-checks/PR-20401/525/git-diff.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/PR-20401/525/git-diff.patch | patch -p1

You can run scram build code-checks to apply code checks directly (this will soon be required for PRs to be considered)

perrozzi · 2017-09-06T14:14:35Z

@pmillet please apply the suggested patch https://cmssdt.cern.ch/SDT/code-checks/PR-20401/525/git-diff.patch and commit/push again

cmsbuild · 2017-09-06T14:17:15Z

The code-checks are being triggered in jenkins.

cmsbuild · 2017-09-06T14:17:16Z

Pull request #20401 was updated. @cmsbuild, @efeyazgan, @perrozzi, @thuer, @govoni can you please check and sign again.

cmsbuild · 2017-09-06T14:19:23Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20401/526

perrozzi · 2017-09-06T14:24:07Z

please test

cmsbuild · 2017-09-06T14:24:24Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22750/console Started: 2017/09/06 16:24

cmsbuild · 2017-09-06T16:46:51Z

-1

Tested at: 366c7b8

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
4c9605a
90a4be0
bfa71fa
3043808
72fcaf9
c8d9643
6aaa765
d0cc21f
aa14a75
484eb14
505e1cc
88641d2
b9e4992
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20401/22750/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20401/22750/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20401/22750/summary.html

I found follow errors while testing this PR

Failed tests: Build ClangBuild

Build:

I found an error when building:

/cvmfs/cms-ib.cern.ch/nweek-02488/slc6_amd64_gcc630/external/thepeg/2.0.4-ghjeda4/include/ThePEG/Pointer/RCPtr.h: In instantiation of 'ThePEG::Pointer::RCPtr& ThePEG::Pointer::RCPtr::create(ThePEG::Pointer::RCPtr::const_reference) [with T = ThePEG::LesHouchesInterface; ThePEG::Pointer::RCPtr::const_reference = const ThePEG::LesHouchesInterface&]':
/cvmfs/cms-ib.cern.ch/nweek-02488/slc6_amd64_gcc630/external/thepeg/2.0.4-ghjeda4/include/ThePEG/Pointer/RCPtr.h:126:22:   required from 'static ThePEG::Pointer::RCPtr ThePEG::Pointer::RCPtr::Create(ThePEG::Pointer::RCPtr::const_reference) [with T = ThePEG::LesHouchesInterface; ThePEG::Pointer::RCPtr::const_reference = const ThePEG::LesHouchesInterface&]'
/cvmfs/cms-ib.cern.ch/nweek-02488/slc6_amd64_gcc630/external/thepeg/2.0.4-ghjeda4/include/ThePEG/Pointer/RCPtr.h:869:69:   required from 'static ThePEG::Pointer::PtrTraits >::pointer ThePEG::Pointer::PtrTraits >::create(ThePEG::Pointer::PtrTraits >::const_reference) [with T = ThePEG::LesHouchesInterface; ThePEG::Pointer::PtrTraits >::pointer = ThePEG::Pointer::RCPtr; ThePEG::Pointer::PtrTraits >::const_reference = const ThePEG::LesHouchesInterface&]'
/cvmfs/cms-ib.cern.ch/nweek-02488/slc6_amd64_gcc630/external/thepeg/2.0.4-ghjeda4/include/ThePEG/Pointer/PtrTraits.h:204:55:   required from 'typename ThePEG::Pointer::Ptr::pointer ThePEG::Pointer::new_ptr(const T&) [with T = ThePEG::LesHouchesInterface; typename ThePEG::Pointer::Ptr::pointer = ThePEG::Pointer::RCPtr]'
/build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_3_X_2017-09-05-2300/src/GeneratorInterface/ThePEGInterface/plugins/ThePEGLesHouchesInterface.cc:38:53:   required from here
/cvmfs/cms-ib.cern.ch/nweek-02488/slc6_amd64_gcc630/external/thepeg/2.0.4-ghjeda4/include/ThePEG/Pointer/RCPtr.h:147:11: error: invalid new-expression of abstract class type 'ThePEG::LesHouchesInterface'
     ptr = new T(t);
           ^~~~~~~~
/build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_3_X_2017-09-05-2300/src/GeneratorInterface/ThePEGInterface/plugins/ThePEGLesHouchesInterface.cc:30:7: note:   because the following virtual functions are pure within 'ThePEG::LesHouchesInterface':
 class LesHouchesInterface : public LesHouchesReader {
       ^~~~~~~~~~~~~~~~~~~

Clang:

I found a compilation error while trying to compile with clang:
I used this command:
scram b vclean && scram build -k -j 16 USER_CXXFLAGS='-fsyntax-only' COMPILER='llvm compile'

>> Compiling  /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_3_X_2017-09-05-2300/src/DataFormats/Common/src/PtrVectorBase.cc 
>> Compiling  /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_3_X_2017-09-05-2300/src/DataFormats/Common/src/ThinnedAssociation.cc 
In file included from /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_3_X_2017-09-05-2300/src/GeneratorInterface/ThePEGInterface/src/ThePEGInterface.cc:22:
In file included from /cvmfs/cms-ib.cern.ch/nweek-02488/slc6_amd64_gcc630/external/thepeg/2.0.4-ghjeda4/include/ThePEG/Repository/Repository.h:16:
In file included from /cvmfs/cms-ib.cern.ch/nweek-02488/slc6_amd64_gcc630/external/thepeg/2.0.4-ghjeda4/include/ThePEG/PDT/ParticleData.h:19:
/cvmfs/cms-ib.cern.ch/nweek-02488/slc6_amd64_gcc630/external/thepeg/2.0.4-ghjeda4/include/ThePEG/Utilities/Selector.h:131:50: error: ISO C++1z does not allow dynamic exception specifications [-Wdynamic-exception-spec]
  T & select(double rnd, double * remainder = 0) throw(range_error);
                                                 ^~~~~~~~~~~~~~~~~~
/cvmfs/cms-ib.cern.ch/nweek-02488/slc6_amd64_gcc630/external/thepeg/2.0.4-ghjeda4/include/ThePEG/Utilities/Selector.h:131:50: note: use 'noexcept(false)' instead
  T & select(double rnd, double * remainder = 0) throw(range_error);
                                                 ^~~~~~~~~~~~~~~~~~

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
4c9605a
90a4be0
bfa71fa
3043808
72fcaf9
c8d9643
6aaa765
d0cc21f
aa14a75
484eb14
505e1cc
88641d2
b9e4992
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20401/22750/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20401/22750/git-merge-result

cmsbuild · 2017-09-06T16:46:53Z

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

cmsbuild · 2017-09-14T07:58:19Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22966/console Started: 2017/09/14 09:59

cmsbuild · 2017-09-14T09:26:49Z

+1

Tested at: 366c7b8
Edited by @smuzaffar: As expected, workflow 534.0 failed due to gridpacks GCC ABI incompatibility

Library_Loader::LoadLibrary(): /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/runTheMatrix-results/534.0_sherpa_ZtoEE_0j_OpenLoops_13TeV_MASTER+sherpa_ZtoEE_0j_OpenLoops_13TeV_MASTER+HARVESTGEN/Process/Amegic/lib/libProc_fsrchannels2.so: undefined symbol: _ZN6PHASIC14Single_Channel4NameEv
Library_Loader::LoadLibrary(): Failed to load library 'libProc_fsrchannels2.so'.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
3f63597
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20401/22966/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20401/22966/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20401/22966/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

RelVals:

When I ran the RelVals I found an error in the following worklfows:
534.0 step1

runTheMatrix-results/534.0_sherpa_ZtoEE_0j_OpenLoops_13TeV_MASTER+sherpa_ZtoEE_0j_OpenLoops_13TeV_MASTER+HARVESTGEN/step1_sherpa_ZtoEE_0j_OpenLoops_13TeV_MASTER+sherpa_ZtoEE_0j_OpenLoops_13TeV_MASTER+HARVESTGEN.log

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
3f63597
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20401/22966/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20401/22966/git-merge-result

cmsbuild · 2017-09-14T09:26:51Z

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

pmillet · 2017-09-14T12:21:22Z

So if I read the log correctly we are back to the gcc incompatibility error as expected. I will update the relval samples for gcc630.

Library_Loader::LoadLibrary(): /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/runTheMatrix-results/534.0_sherpa_ZtoEE_0j_OpenLoops_13TeV_MASTER+sherpa_ZtoEE_0j_OpenLoops_13TeV_MASTER+HARVESTGEN/Process/Amegic/lib/libProc_fsrchannels2.so: undefined symbol: _ZN6PHASIC14Single_Channel4NameEv
Library_Loader::LoadLibrary(): Failed to load library 'libProc_fsrchannels2.so'.

pmillet · 2017-09-15T11:03:43Z

@efeyazgan, @perrozzi, @thuer, @govoni @davidlange6 - anything preventing this from being included? its needed for Sherpa to work with cms-sw/cmsdist#3405 (merged)

perrozzi · 2017-09-15T11:19:42Z

+1

cmsbuild · 2017-09-15T11:20:03Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

perrozzi · 2017-09-15T11:21:00Z

I was actually waiting for #20515 to be merged in order to re-run the tests. From the pure GEN point of view this is good to go, approved.

davidlange6 · 2017-09-15T12:52:55Z

GeneratorInterface/SherpaInterface/src/SherpaHadronizer.cc

@@ -66,7 +69,7 @@ class SherpaHadronizer : public gen::BaseHadronizer {
  edm::ParameterSet  SherpaParameterSet;
  unsigned int maxEventsToPrint;
  std::vector<std::string> arguments;
-  SHERPA::Sherpa Generator;
+  SHERPA::Sherpa *Generator = new SHERPA::Sherpa();


hi @pmillet - please make this a smart pointer.

davidlange6 · 2017-09-15T12:54:12Z

GeneratorInterface/SherpaInterface/src/SherpaHadronizer.cc

  isInitialized=false;
 //initialization of Sherpa moved to initializeForInternalPartons
 }

 SherpaHadronizer::~SherpaHadronizer()
 {
+  Generator->~Sherpa();
+  #ifdef USING__MPI
+    MPI::Finalize();


so this is a sign that you can not use the default CMSSW builds.. have you considered run time switches to provide this same functionality?

@davidlange6 -
sherpa is either compiled with or without mpi support, so runtime switches are not an option

if it is compiled with mpi support it needs the mpi init and finalize calls even if it is not
parallelized using mpi (this is the case here)

davidlange6 · 2017-09-18T09:06:32Z

merge

bugfix for sherpa compiled with openmpi support

a917599

cmsbuild added this to the CMSSW_9_4_X milestone Sep 6, 2017

cmsbuild added code-checks-pending comparison-pending generators-pending orp-pending pending-signatures tests-pending labels Sep 6, 2017

cmsbuild added code-checks-rejected and removed code-checks-pending labels Sep 6, 2017

code-checks changes for SherpaHadronizer

366c7b8

cmsbuild added code-checks-pending and removed code-checks-rejected labels Sep 6, 2017

cmsbuild added code-checks-approved and removed code-checks-pending labels Sep 6, 2017

cmsbuild added tests-started and removed tests-pending labels Sep 6, 2017

cmsbuild removed comparison-pending tests-started labels Sep 6, 2017

cmsbuild added comparison-pending tests-pending and removed comparison-available tests-approved labels Sep 14, 2017

cmsbuild added tests-started and removed tests-pending labels Sep 14, 2017

cmsbuild added comparison-notrun tests-rejected tests-approved and removed comparison-pending tests-started tests-rejected labels Sep 14, 2017

smuzaffar mentioned this pull request Sep 14, 2017

updated relval gridpacks for gcc630 #20515

Merged

cmsbuild added fully-signed generators-approved and removed generators-pending pending-signatures labels Sep 15, 2017

davidlange6 reviewed Sep 15, 2017

View reviewed changes

cmsbuild merged commit 3f53835 into cms-sw:master Sep 18, 2017

pmillet mentioned this pull request Sep 18, 2017

Sherpa openmpi support #20564

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bugfix for sherpa compiled with openmpi support #20401

bugfix for sherpa compiled with openmpi support #20401

pmillet commented Sep 6, 2017

cmsbuild commented Sep 6, 2017

cmsbuild commented Sep 6, 2017

cmsbuild commented Sep 6, 2017

perrozzi commented Sep 6, 2017

cmsbuild commented Sep 6, 2017

cmsbuild commented Sep 6, 2017

cmsbuild commented Sep 6, 2017

perrozzi commented Sep 6, 2017

cmsbuild commented Sep 6, 2017 •

edited

cmsbuild commented Sep 6, 2017

cmsbuild commented Sep 6, 2017

cmsbuild commented Sep 14, 2017 •

edited

cmsbuild commented Sep 14, 2017 •

edited by smuzaffar

cmsbuild commented Sep 14, 2017

pmillet commented Sep 14, 2017

pmillet commented Sep 15, 2017 •

edited

perrozzi commented Sep 15, 2017

cmsbuild commented Sep 15, 2017

perrozzi commented Sep 15, 2017

davidlange6 Sep 15, 2017

davidlange6 Sep 15, 2017

pmillet Sep 15, 2017 •

edited

davidlange6 commented Sep 18, 2017

bugfix for sherpa compiled with openmpi support #20401

bugfix for sherpa compiled with openmpi support #20401

Conversation

pmillet commented Sep 6, 2017

cmsbuild commented Sep 6, 2017

cmsbuild commented Sep 6, 2017

cmsbuild commented Sep 6, 2017

perrozzi commented Sep 6, 2017

cmsbuild commented Sep 6, 2017

cmsbuild commented Sep 6, 2017

cmsbuild commented Sep 6, 2017

perrozzi commented Sep 6, 2017

cmsbuild commented Sep 6, 2017 • edited

cmsbuild commented Sep 6, 2017

cmsbuild commented Sep 6, 2017

cmsbuild commented Sep 14, 2017 • edited

cmsbuild commented Sep 14, 2017 • edited by smuzaffar

cmsbuild commented Sep 14, 2017

pmillet commented Sep 14, 2017

pmillet commented Sep 15, 2017 • edited

perrozzi commented Sep 15, 2017

cmsbuild commented Sep 15, 2017

perrozzi commented Sep 15, 2017

davidlange6 Sep 15, 2017

Choose a reason for hiding this comment

davidlange6 Sep 15, 2017

Choose a reason for hiding this comment

pmillet Sep 15, 2017 • edited

Choose a reason for hiding this comment

davidlange6 commented Sep 18, 2017

cmsbuild commented Sep 6, 2017 •

edited

cmsbuild commented Sep 14, 2017 •

edited

cmsbuild commented Sep 14, 2017 •

edited by smuzaffar

pmillet commented Sep 15, 2017 •

edited

pmillet Sep 15, 2017 •

edited