enable python extension for fastjet

[smuzaffar]

No description provided.

[smuzaffar]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27043/console

[cmsbuild]

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_10_1_X/gcc630.

@cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

[smuzaffar]

@mrodozov , can you please check how to enable python interface or fastjet?

[mrodozov]

@rappoccio , we were trying to enable python support for fastjet when the following broke the build:

make[2]: Entering directory `/build/mrodozov/build_fastjet/BUILD/slc6_amd64_gcc630/external/fastjet/3.3.0-cms/fastjet-3.3.0/pyinterface'
/bin/sh ../libtool  --tag=CXX --silent  --mode=compile g++ -DHAVE_CONFIG_H -I. -I../include/fastjet  -I/build/mrodozov/build_fastjet/slc6_amd64_gcc630/external/python/2.7.11-fjcbno/include/python2.7 -I/build/mrodozov/build_fastjet/slc6_amd64_gcc630/external/python/2.7.11-fjcbno/include/python2.7 -g  -Woverloaded-virtual  -DDROP_CGAL   -I../include -I../include -I../tools -DSWIG  -g  -Woverloaded-virtual  -DDROP_CGAL  -O3 -Wall -ffast-math -ftree-vectorize -msse3 -MT _fastjet_la-swig_wrap.lo -MD -MP -MF .deps/_fastjet_la-swig_wrap.Tpo -c -o _fastjet_la-swig_wrap.lo `test -f 'swig_wrap.cpp' || echo './'`swig_wrap.cpp
swig_wrap.cpp: In function 'std::__cxx11::string fastjet_Error___str__(const fastjet::Error*)':
swig_wrap.cpp:5244:87: error: 'const class fastjet::Error' has no member named 'description'
SWIGINTERN std::string fastjet_Error___str__(fastjet::Error const *self){return self->description();}
^~~~~~~~~~~
swig_wrap.cpp: In function 'PyObject* _wrap_Error_description(PyObject*, PyObject*)':
swig_wrap.cpp:9470:48: error: 'const class fastjet::Error' has no member named 'description'
result = ((fastjet::Error const *)arg1)->description();

where the file fastjet/3.3.0-cms/fastjet-3.3.0/pyinterface/swig_wrap.cpp complained that there is no method description in the fastjet::Error class. So I went to check the class definition and I noticed that
cms-externals/fastjet@156108f#diff-a15fd2fb4d8b1a8d12b7666facb52109L66
the method has been removed. I noticed you've removed entirely the declaration of the description method - have you done that by accident (so we could bring the declaration back) or the method is removed on purpose ?
Thanks & cheers,
M.

[rappoccio]

I think this must have been removed by a previous patch (I apply all of them) for thread safety. If this is safe from a thread standpoint (I think it looks to be so to me) then we can safely bring it back in.

[cmsbuild]

-1

Tested at: 7edb4e2

• Build:

I found an error when building:

checking for python platform... linux2
checking for python script directory... ${prefix}/lib/python2.6/site-packages
checking for python extension module directory... ${exec_prefix}/lib64/python2.6/site-packages
checking for python2.6-config... no
checking for python-config... no
configure: error: cannot find python-config for /usr/bin/python.
error: Bad exit status from /build/cmsbld/jenkins/workspace/ib-any-integration/testBuildDir/tmp/rpm-tmp.mZI4iQ (%prep)


RPM build errors:
Bad exit status from /build/cmsbld/jenkins/workspace/ib-any-integration/testBuildDir/tmp/rpm-tmp.mZI4iQ (%prep)


You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3865/27043/summary.html

[rappoccio]

Is this somehow looking for python 2.6 instead of 2.7?

[davidlange6]

it found the system python not our python - it looks like a dependency on python is missing from fastjet.spec

…

On Mar 22, 2018, at 5:13 PM, rappoccio ***@***.***> wrote: Is this somehow looking for python 2.6 instead of 2.7? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

[mrodozov]

Yes the dep was missing I've added it in #3867 as I can't put commits on top of this PR. I'm closing this one