Bring python support for fastjet #3867
Conversation
This PR updates #3865 with a change to bring a declaration mrodozov/fastjet@acfff3b so that we apply only the final changes in cms-externals/fastjet (eventually)
|
A new Pull Request was created by @mrodozov (Mircho Rodozov) for branch IB/CMSSW_10_1_X/gcc630. @cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks. |
Bring back our official fork and add BuildRequires: python. Local test went fine
|
Pull request #3867 was updated. |
|
please test |
|
The tests are being triggered in jenkins. |
|
hi @mrodozov - I think this should also have a fastjet-toolfile.spec update to put the fastjet python into our PYTHON(27)PATH |
|
-1 Tested at: d3caa36 You can see the results of the tests here: I found follow errors while testing this PR Failed tests: AddOn
I found errors in the following addon tests: cmsDriver.py TTbar_13TeV_TuneCUETP8M1_cfi --conditions auto:run2_mc --fast -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,EI,VALIDATION --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot NominalCollision2015 --era Run2_2016 : FAILED - time: date Thu Mar 22 20:56:17 2018-date Thu Mar 22 20:50:40 2018 s - exit: 16640 |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
please test |
|
The tests are being triggered in jenkins. |
cmsbuild
added
tests-pending
tests-started
and removed
tests-rejected
tests-pending
labels
|
-1 Tested at: d3caa36
I found an error when building: * The action "install-external+py2-pippkgs_depscipy-toolfile+1.0-jpkldn" was not completed successfully because Traceback (most recent call last): File "/build/cmsbld/jenkins/workspace/ib-any-integration/PKGTOOLS/scheduler.py", line 199, in doSerial result = commandSpec[0](*commandSpec[1:]) File "PKGTOOLS/cmsBuild", line 2784, in installApt RpmInstallFailed: Failed to install package py2-pippkgs_depscipy-toolfile. Reason: error: Failed dependencies: libldap_r-2.4.so.2()(64bit) is needed by external+py2-pippkgs+6.0-jpkldn-1-1.x86_64 Reading Package Lists... Get:1 http://cmsrep.cern.ch cmssw/cms.week0/slc6_amd64_gcc630 external+py2-pippkgs_depscipy-toolfile+1.0-jpkldn-1-1.slc6_amd64_gcc630.rpm Building Dependency Tree... The following NEW packages will be installed: You can see the results of the tests here: |
|
hum - likely a real missing dependency (due to my pr yesterday) [but it didn't turn up in my tests or the IB)
… On Mar 23, 2018, at 9:28 AM, cmsbuild ***@***.***> wrote:
-1
Tested at: d3caa36
• Build:
I found an error when building:
* The action "install-external+py2-pippkgs_depscipy-toolfile+1.0-jpkldn" was not completed successfully because Traceback (most recent call last):
File "/build/cmsbld/jenkins/workspace/ib-any-integration/PKGTOOLS/scheduler.py", line 199, in doSerial
result = commandSpec[0](*commandSpec[1:])
File "PKGTOOLS/cmsBuild", line 2784, in installApt
RpmInstallFailed: Failed to install package py2-pippkgs_depscipy-toolfile. Reason:
error: Failed dependencies:
libldap_r-2.4.so.2()(64bit) is needed by external+py2-pippkgs+6.0-jpkldn-1-1.x86_64
Reading Package Lists...
Get:1 http://cmsrep.cern.ch cmssw/cms.week0/slc6_amd64_gcc630 external+py2-pippkgs_depscipy-toolfile+1.0-jpkldn-1-1.slc6_amd64_gcc630.rpm
Building Dependency Tree...
The following NEW packages will be installed:
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3867/27060/summary.html
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
The tests are being triggered in jenkins. |
|
-1 Tested at: 825a335 You can see the results of the tests here: I found follow errors while testing this PR Failed tests: UnitTests
I found errors in the following unit tests: ---> test testhep_ml had ERRORS |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
+externals |
cmsbuild
added
externals-approved
fully-signed
and removed
externals-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_10_1_X/gcc630 IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
Comparison is ready Comparison Summary:
|
|
Just curious, when should this show up on cvmfs? I still don't see the python extensions: cmslpc27:$ ls /cvmfs/cms.cern.ch/slc6_amd64_gcc630/external/fastjet/3.3.0/lib/ |
|
For /cvmfs/cms.cern.ch , it will be deployed along with next release i.e 10.1.0 (in couple of days I guess). But it is already available in IBs |
|
Thanks @smuzaffar! |
This updates #3865 with a change to bring a declaration mrodozov/fastjet@acfff3b so that we apply only the final changes in cms-externals/fastjet (eventually)
@rappoccio , @smuzaffar