Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PhysicsTools-NanoAOD to tag V01-00-02 #3887

Merged
merged 1 commit into from Mar 30, 2018

Conversation

mrodozov
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mrodozov (Mircho Rodozov) for branch IB/CMSSW_10_1_X/gcc630.

@cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@mrodozov
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

backport done
Successfully backported PR #3887 as #3888 for branch IB/CMSSW_9_4_X/gcc630

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 28, 2018

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3887/27161/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 29
  • DQMHistoTests: Total histograms compared: 2501822
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2501640
  • DQMHistoTests: Total skipped: 176
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.910000000054 KiB( 22 files compared)
  • Checked 119 log files, 9 edm output root files, 29 DQM output files

@cmsbuild
Copy link
Contributor

-1

Tested at: 03b4aa1

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22755/27164/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

  • Unit Tests:

I found errors in the following unit tests:

---> test runtestPhysicsToolsNanoAOD had ERRORS

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 28, 2018

The tests are being triggered in jenkins.
Using cmssw from cms-sw/cmssw#22755
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27171/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@mrodozov
Copy link
Contributor Author

+externals

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_10_1_X/gcc630 IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

@smuzaffar @mrodozov it is ok to integrate this package, but this should now go to IB/CMSSW_10_2_X/gcc630

@smuzaffar smuzaffar changed the base branch from IB/CMSSW_10_1_X/gcc630 to IB/CMSSW_10_2_X/gcc630 March 29, 2018 16:24
@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@smuzaffar
Copy link
Contributor

abort

@cmsbuild
Copy link
Contributor

Jenkins tests are aborted.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 29, 2018

The tests are being triggered in jenkins.
Using cmssw from cms-sw/cmssw#22755
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27199/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit a13d399 into IB/CMSSW_10_2_X/gcc630 Mar 30, 2018
@smuzaffar smuzaffar deleted the mrodozov-patch-2 branch April 11, 2018 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants