Update llvm/clang to version 7.0.0 (release) #4359
Conversation
Llvm 7 includes a new tool, llvm-exegesis, that depepnds on libpfm.so. Rather than including this library in the CMSSW stack, we assume that it will be available form the host system; as it's not something strictly necessary to have, we avoid a hard dependency on it in the RPM package.
|
please test |
|
The tests are being triggered in jenkins. |
|
A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_10_3_X/gcc700. @cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks.
|
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+externals |
|
This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_10_3_X/gcc700 IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
cmsbuild
added
externals-approved
fully-signed
and removed
externals-pending
pending-signatures
labels
|
hold |
|
Pull request has been put on hold by @smuzaffar |
smuzaffar
changed the base branch from
IB/CMSSW_10_3_X/gcc700
to
IB/CMSSW_10_4_X/gcc700
|
please test |
|
The tests are being triggered in jenkins. |
|
unhold |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+externals |
cmsbuild
added
externals-approved
fully-signed
and removed
externals-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_10_4_X/gcc700 IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
| @@ -25,8 +25,8 @@ Requires: py2-bottleneck | |||
| Requires: py2-downhill | |||
| Requires: py2-theanets | |||
| Requires: py2-xgboost | |||
| Requires: py2-llvmlite | |||
| Requires: py2-numba | |||
| #Requires: py2-llvmlite | |||
There was a problem hiding this comment.
@smuzaffar this seems to trigger a couple of failures in the unit tests of PythonAnalysis since CMSSW_10_4_X_2018-10-11-2300 because these tools are not found in the import. Is this needed?
|
the unit test should be updated to remove the two imports corresponding to these packages until llvmlite supports llvm7 (presumably soon)
… On Oct 15, 2018, at 10:37 AM, Fabio Cossutti ***@***.***> wrote:
@fabiocos commented on this pull request.
In python_tools.spec:
> @@ -25,8 +25,8 @@ Requires: py2-bottleneck
Requires: py2-downhill
Requires: py2-theanets
Requires: py2-xgboost
-Requires: py2-llvmlite
-Requires: py2-numba
+#Requires: py2-llvmlite
@smuzaffar this seems to trigger a couple of failures in the unit tests of PythonAnalysis since CMSSW_10_4_X_2018-10-11-2300 because these tools are not found in the import. Is this needed?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
@davidlange6 provided we do not forget about them. I am not sure whether it is better to temporarily remove the two tests and keep a github issue open (we have plenty of them), or declare them as known to fail in the IB, but at least we keep track of them |
|
right - either way - the downside to unit tests that fail is that any PR that checks out this package will fail tests..
… On Oct 15, 2018, at 10:58 AM, Fabio Cossutti ***@***.***> wrote:
@davidlange6 provided we do not forget about them. I am not sure whether it is better to temporarily remove the two tests and keep a github issue open (we have plenty of them), or declare them as known to fail in the IB, but at least we keep track of them
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
yes, this is also an issue to be taken into account, people might get confused by failures unrelated to their changes. Ok, I will go for the former solution |
backport of #4353
For the moment, skip building numba and llvmlite, until they support LLVM 7.