Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dablooms spec and dablooms-toolfile spec so dablooms library can be linked by StaticAnalyzers library #4436

Merged
merged 6 commits into from Oct 20, 2018

Conversation

gartung
Copy link
Member

@gartung gartung commented Oct 19, 2018

No description provided.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @gartung (Patrick Gartung) for branch IB/CMSSW_10_4_X/gcc700.

@cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@gartung
Copy link
Member Author

gartung commented Oct 19, 2018

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 19, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31165/console

@cmsbuild
Copy link
Contributor

Pull request #4436 was updated.

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 19, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31169/console

@cmsbuild
Copy link
Contributor

Pull request #4436 was updated.

@gartung gartung changed the title Add back py2-dablooms and add a toolfile so library can be linked by StaticAnalyser library Add dablooms spec and dablooms-toolfile spec so dablooms library can be linked by StaticAnalyzers library Oct 19, 2018
py2-dablooms.spec Outdated Show resolved Hide resolved
@gartung
Copy link
Member Author

gartung commented Oct 19, 2018 via email

@gartung
Copy link
Member Author

gartung commented Oct 19, 2018 via email

@smuzaffar
Copy link
Contributor

you do not need separate spec for that just run make install prefix=%i in the %install section

@@ -140,7 +140,7 @@ Requires: py2-matplotlib
Requires: py2-numpy-toolfile
Requires: py2-sqlalchemy
Requires: py2-pygithub
#Requires: py2-dablooms
Requires: py2-dablooms
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make this py2-dablooms-toolfile and remove it from cmssw-tool-conf

@cmsbuild
Copy link
Contributor

Pull request #4436 was updated.

@cmsbuild
Copy link
Contributor

Pull request #4436 was updated.

@gartung
Copy link
Member Author

gartung commented Oct 19, 2018

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 19, 2018

@smuzaffar
Copy link
Contributor

@gartung , I have started the test with cms-sw/cmssw#24949 to make sure that pydablooms is available in cmssw env.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 19, 2018

The tests are being triggered in jenkins.
Using cmssw from cms-sw/cmssw#24946
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31178/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4436/31174/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 2994843
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2994645
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 134 log files, 14 edm output root files, 32 DQM output files

@smuzaffar
Copy link
Contributor

+externals

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_10_4_X/gcc700 IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@smuzaffar smuzaffar merged commit 7132697 into cms-sw:IB/CMSSW_10_4_X/gcc700 Oct 20, 2018
@gartung gartung deleted the dablooms-update branch May 4, 2021 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants