New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dablooms spec and dablooms-toolfile spec so dablooms library can be linked by StaticAnalyzers library #4436
Add dablooms spec and dablooms-toolfile spec so dablooms library can be linked by StaticAnalyzers library #4436
Conversation
A new Pull Request was created by @gartung (Patrick Gartung) for branch IB/CMSSW_10_4_X/gcc700. @cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks. |
@cmsbuild please test |
The tests are being triggered in jenkins. |
Pull request #4436 was updated. |
please test |
The tests are being triggered in jenkins. |
49b5671
to
35cf6fa
Compare
Pull request #4436 was updated. |
I moved the dablooms library build to its own spec and toolfile spec.
|
I was not sure that I could have a python package that also provided a library to link to.
|
you do not need separate spec for that just run |
python_tools.spec
Outdated
@@ -140,7 +140,7 @@ Requires: py2-matplotlib | |||
Requires: py2-numpy-toolfile | |||
Requires: py2-sqlalchemy | |||
Requires: py2-pygithub | |||
#Requires: py2-dablooms | |||
Requires: py2-dablooms |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make this py2-dablooms-toolfile
and remove it from cmssw-tool-conf
Pull request #4436 was updated. |
Pull request #4436 was updated. |
please test |
The tests are being triggered in jenkins. |
The tests are being triggered in jenkins. |
@gartung , I have started the test with cms-sw/cmssw#24949 to make sure that pydablooms is available in cmssw env. |
The tests are being triggered in jenkins. |
Comparison job queued. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+externals |
This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_10_4_X/gcc700 IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
Comparison job queued. |
No description provided.