Update Utilities/StaticAnalyzers to use dablooms library added in CMSDIST PR 4436

[gartung]

No description provided.

[cmsbuild]

The code-checks are being triggered in jenkins.

[gartung]

Requires CMSDIST 4436
cms-sw/cmsdist#4436

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24946/6917

[cmsbuild]

A new Pull Request was created by @gartung (Patrick Gartung) for master.

It involves the following packages:

Utilities/StaticAnalyzers

@cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @wddgit this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[gartung]

please test with cms-sw/cmsdist#4436

[cmsbuild]

The tests are being triggered in jenkins.
Using externals from cms-sw/cmsdist#4436
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31178/console

[cmsbuild]

+1
Tested at: d7afa86
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24946/31178/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24946/31178/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 2994843
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2994645
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 134 log files, 14 edm output root files, 32 DQM output files

[smuzaffar]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1

[gartung]

@smuzaffar It looks like I did not include the headers from libdablooms correctly.

https://cmssdt.cern.ch/SDT/jenkins-artifacts/ib-static-analysis/CMSSW_10_4_X_2018-10-21-2300/slc6_amd64_gcc700/llvm-analysis/failures/clang_other_error_00OUoE.ii.stderr.txt

[smuzaffar]

this is because dablooms.* files were patches in cmssw. Can you please provide a Pr based on https://github.com/cms-externals/dablooms/tree/cms/master/cac1c09https://github.com/cms-externals/dablooms/tree/cms/master/cac1c09 ( which is tip of dablooms master). Cheers, --Shahzad

…

________________________________ From: Patrick Gartung [notifications@github.com] Sent: 22 October 2018 18:24 To: cms-sw/cmssw Cc: Malik Shahzad Muzaffar; Mention Subject: Re: [cms-sw/cmssw] Update Utilities/StaticAnalyzers to use dablooms library added in CMSDIST PR 4436 (#24946) @smuzaffar<https://github.com/smuzaffar> It looks like I did not include the headers from libdablooms correctly. https://cmssdt.cern.ch/SDT/jenkins-artifacts/ib-static-analysis/CMSSW_10_4_X_2018-10-21-2300/slc6_amd64_gcc700/llvm-analysis/failures/clang_other_error_00OUoE.ii.stderr.txt — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#24946 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AD7KwqqKZWlh3TU-A6F6AVRapilYhLiAks5unfE_gaJpZM4XweQs>.

[gartung]

See #24964

[smuzaffar]

ah ok