Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update data SLHCUpgradeSimulations-Geometry #4723

Conversation

mrodozov
Copy link
Contributor

@mrodozov mrodozov commented Feb 22, 2019

Description in cms-data/SLHCUpgradeSimulations-Geometry#11
Resolves: #4721
Needed for cms-sw/cmssw#25988 (?)

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mrodozov (Mircho Rodozov) for branch IB/CMSSW_10_6_X/gcc700.

@cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 22, 2019

The tests are being triggered in jenkins.
Using cmssw from cms-sw/cmssw#25988
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33225/console

@cmsbuild
Copy link
Contributor

-1

Tested at: e826603

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25988/33225/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

  • RelVals:

When I ran the RelVals I found an error in the following workflows:
10224.0 step2

runTheMatrix-results/10224.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017PU_GenSimFull+DigiFullPU_2017PU+RecoFullPU_2017PU+HARVESTFullPU_2017PU/step2_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017PU_GenSimFull+DigiFullPU_2017PU+RecoFullPU_2017PU+HARVESTFullPU_2017PU.log

@cmsbuild
Copy link
Contributor

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
Using cmssw from cms-sw/cmssw#25988

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 26, 2019

The tests are being triggered in jenkins.
Using cmssw from cms-sw/cmssw#25988
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33295/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25988/33295/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-25988/28634.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D40_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D40+RecoFullGlobal_2023D40+HARVESTFullGlobal_2023D40

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3098286
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3098088
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 133 log files, 14 edm output root files, 32 DQM output files

@cmsbuild
Copy link
Contributor

Pull request #4723 was updated.

@smuzaffar
Copy link
Contributor

+externals
data external itself just adds a new file ( https://github.com/cms-data/SLHCUpgradeSimulations-Geometry/pull/11/files ), so it can be merged without cmssw.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33388/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2019

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_10_6_X/gcc700 IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Mar 4, 2019

+1

@smuzaffar smuzaffar merged commit b7f4d44 into IB/CMSSW_10_6_X/gcc700 Mar 4, 2019
@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4723/33388/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3114826
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3114628
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 133 log files, 14 edm output root files, 32 DQM output files

@smuzaffar smuzaffar deleted the update-data-SLHCUpgradeSimulations-Geometry-to-new-tag branch March 5, 2019 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants