adding VBFNLO and Hjets++ to the externals linked to Herwig7 #4753

Andrej-CMS · 2019-03-06T07:21:22Z

No description provided.

cmsbuild · 2019-03-06T07:21:47Z

A new Pull Request was created by @Andrej-CMS for branch IB/CMSSW_10_6_X/gcc700.

@cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

smuzaffar · 2019-03-06T07:55:24Z

vbfnlo.spec

@@ -0,0 +1,24 @@
+### RPM external vbfnlo 3.0.0beta5
+Source: http://www.itp.kit.edu/~vbfnloweb/archive/vbfnlo-%{realversion}.tgz


@Andrej-CMS , why not use https://github.com/vbfnlo/vbfnlo to download it? You can use

git+https://github.com/vbfnlo/%{n}.git?obj=master/v%{realversion}&export=%{n}-%{realversion}&output=/%{n}-%{realversion}.tgz

and then can do

%setup -q -n %{n}-%{realversion}

Dear @smuzaffar ,
I get now an error that states that the Manual.pdf file cannot be compiled from TeX file. Do we have in cmsdist some latex package that need to build first?
vbfnlobuild.txt

@smuzaffar
do you have any idea in regards of the question above?

@Andrej-CMS , I do not see build errors if I run autoreconf -vi before configure

smuzaffar · 2019-03-06T07:56:25Z

@Andrej-CMS , do we have any tests in CMSSW to test hjets?

cmsbuild · 2019-03-06T09:06:08Z

Pull request #4753 was updated.

Andrej-CMS · 2019-03-06T09:07:13Z

@smuzaffar
thanks for your comments!
I changed to download from git. We don't have the hjets test yet. Do you want me to add a runTheMatrix command?

smuzaffar · 2019-03-06T10:29:46Z

@Andrej-CMS , at least a unit test to make sure that our distribution of hjets is good/working

Andrej-CMS · 2019-03-06T10:36:59Z

@smuzaffar
sure, I can add that. Could you maybe in the meantime try to build this here?
I had quite some issues building these packages, but this version here at least worked for me locally

smuzaffar · 2019-03-06T13:57:01Z

please test

cmsbuild · 2019-03-06T13:57:26Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33433/console

cmsbuild · 2019-03-06T14:14:28Z

-1

Tested at: 7caa456

Build:

I found compilation error when building:

+ CC=/build/cmsbld/jenkins/workspace/ib-any-integration/testBuildDir/slc7_amd64_gcc700/external/gcc/7.0.0-omkpbe2/bin/gcc
++ which gfortran
+ FC=/build/cmsbld/jenkins/workspace/ib-any-integration/testBuildDir/slc7_amd64_gcc700/external/gcc/7.0.0-omkpbe2/bin/gfortran
+ ./configure --prefix=/build/cmsbld/jenkins/workspace/ib-any-integration/testBuildDir/tmp/BUILDROOT/608f29fd9a397d473ce59ff03edd9f22/opt/cmssw/slc7_amd64_gcc700/external/vbfnlo/3.0.0beta5 --enable-processes=vbf,hjjj FC=/build/cmsbld/jenkins/workspace/ib-any-integration/testBuildDir/slc7_amd64_gcc700/external/gcc/7.0.0-omkpbe2/bin/gfortran FCFLAGS=-std=legacy
/build/cmsbld/jenkins/workspace/ib-any-integration/testBuildDir/tmp/rpm-tmp.CtwoJG: line 34: ./configure: No such file or directory
error: Bad exit status from /build/cmsbld/jenkins/workspace/ib-any-integration/testBuildDir/tmp/rpm-tmp.CtwoJG (%build)


RPM build errors:
Bad exit status from /build/cmsbld/jenkins/workspace/ib-any-integration/testBuildDir/tmp/rpm-tmp.CtwoJG (%build)

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4753/33433/summary.html

mrodozov · 2019-03-12T13:18:21Z

please test

cmsbuild · 2019-03-12T13:18:58Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33538/console

cmsbuild · 2019-03-12T14:17:17Z

-1

Tested at: 7caa456

Build:

I found compilation error when building:

+ CC=/build/cmsbld/jenkins/workspace/ib-any-integration/testBuildDir/slc7_amd64_gcc700/external/gcc/7.0.0-omkpbe2/bin/gcc
++ which gfortran
+ FC=/build/cmsbld/jenkins/workspace/ib-any-integration/testBuildDir/slc7_amd64_gcc700/external/gcc/7.0.0-omkpbe2/bin/gfortran
+ ./configure --prefix=/build/cmsbld/jenkins/workspace/ib-any-integration/testBuildDir/tmp/BUILDROOT/608f29fd9a397d473ce59ff03edd9f22/opt/cmssw/slc7_amd64_gcc700/external/vbfnlo/3.0.0beta5 --enable-processes=vbf,hjjj FC=/build/cmsbld/jenkins/workspace/ib-any-integration/testBuildDir/slc7_amd64_gcc700/external/gcc/7.0.0-omkpbe2/bin/gfortran FCFLAGS=-std=legacy
/build/cmsbld/jenkins/workspace/ib-any-integration/testBuildDir/tmp/rpm-tmp.nDzFao: line 34: ./configure: No such file or directory
error: Bad exit status from /build/cmsbld/jenkins/workspace/ib-any-integration/testBuildDir/tmp/rpm-tmp.nDzFao (%build)


RPM build errors:
Bad exit status from /build/cmsbld/jenkins/workspace/ib-any-integration/testBuildDir/tmp/rpm-tmp.nDzFao (%build)

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4753/33538/summary.html

smuzaffar · 2019-03-12T22:21:09Z

vbfnlo.spec

+CXX="$(which g++) -std=c++11"
+CC="$(which gcc)"
+FC="$(which gfortran)"
+


@Andrej-CMS , as mentioned in https://github.com/vbfnlo/vbfnlo/blob/master/README.md , you need to run autoreconf -vi before running configure

cmsbuild · 2019-05-20T12:46:29Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/348/console Started: 2019/05/20 15:33

cmsbuild · 2019-05-20T12:46:31Z

Pull request #4753 was updated.

cmsbuild · 2019-05-20T16:59:25Z

+1
Tested at: d6b7a12
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ff8518/348/summary.html

cmsbuild · 2019-05-20T16:59:29Z

Comparison job queued.

cmsbuild · 2019-05-20T19:41:27Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ff8518/348/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 33
DQMHistoTests: Total histograms compared: 3206828
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3206493
DQMHistoTests: Total skipped: 334
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
Checked 137 log files, 14 edm output root files, 33 DQM output files

smuzaffar · 2019-05-20T20:01:33Z

+externals
@alberto-sanchez,@perrozzi,@efeyazgan,@qliphy can you please sign this?

qliphy · 2019-05-21T00:02:56Z

+1

cmsbuild · 2019-05-21T00:04:33Z

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_11_0_X/gcc700 IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

smuzaffar · 2019-05-21T09:35:15Z

@fabiocos , this is ready to go in too.

fabiocos · 2019-05-21T20:31:31Z

+1

smuzaffar · 2019-06-06T13:39:59Z

@Andrej-CMS , HJets failed to compile with GCC 9

https://cmssdt.cern.ch/SDT/jenkins-artifacts/build-any-ib/CMSSW_11_0_X_2019-06-05-2300/slc7_amd64_gcc900/76593/external/hjets/1.2/log

  CXX      HJetsProcessInfo.lo
In file included from /build/cmsbld/jenkins/workspace/build-any-ib/w/slc7_amd64_gcc900/external/thepeg/2.1.5/include/ThePEG/Config/Complex.h:16,
                 from /build/cmsbld/jenkins/workspace/build-any-ib/w/slc7_amd64_gcc900/external/thepeg/2.1.5/include/ThePEG/Config/ThePEG.h:31,
                 from HJetsProcessInfo.h:13,
                 from HJetsProcessInfo.cc:11:
/build/cmsbld/jenkins/workspace/build-any-ib/w/slc7_amd64_gcc900/external/gcc/9.0.0-nmpfii/include/c++/9.1.1/complex: In instantiation of 'std::complex<double>& std::complex<double>::operator=(const std::complex<_Tp>&) [with _Tp = ThePEG::Qty<0, 0, 0>]':
HJetsProcessInfo.cc:240:93:   required from here
/build/cmsbld/jenkins/workspace/build-any-ib/w/slc7_amd64_gcc900/external/gcc/9.0.0-nmpfii/include/c++/9.1.1/complex:1319:19: error: 'const struct std::complex<ThePEG::Qty<0, 0, 0> >' has no member named '__rep'
 1319 |    _M_value = __z.__rep();
      |               ~~~~^~~~~
make[1]: *** [HJetsProcessInfo.lo] Error 1
make[1]: *** Waiting for unfinished jobs....
In file included from /build/cmsbld/jenkins/workspace/build-any-ib/w/slc7_amd64_gcc900/external/thepeg/2.1.5/include/ThePEG/Config/Complex.h:16,
                 from /build/cmsbld/jenkins/workspace/build-any-ib/w/slc7_amd64_gcc900/external/thepeg/2.1.5/include/ThePEG/Config/ThePEG.h:31,
                 from /build/cmsbld/jenkins/workspace/build-any-ib/w/slc7_amd64_gcc900/external/thepeg/2.1.5/include/ThePEG/Interface/Interfaced.h:13,
                 from /build/cmsbld/jenkins/workspace/build-any-ib/w/slc7_amd64_gcc900/external/thepeg/2.1.5/include/ThePEG/Handlers/HandlerBase.h:13,
                 from /build/cmsbld/jenkins/workspace/build-any-ib/w/slc7_amd64_gcc900/external/thepeg/2.1.5/include/ThePEG/MatrixElement/Amplitude.h:14,
                 from /build/cmsbld/jenkins/workspace/build-any-ib/w/slc7_amd64_gcc900/external/herwigpp/7.1.5/include/Herwig/MatrixElement/Matchbox/Base/MatchboxAmplitude.h:15,
                 from AmplitudeBase.h:16,
                 from AmplitudeBase.cc:15:
/build/cmsbld/jenkins/workspace/build-any-ib/w/slc7_amd64_gcc900/external/gcc/9.0.0-nmpfii/include/c++/9.1.1/complex: In instantiation of 'std::complex<double>& std::complex<double>::operator=(const std::complex<_Tp>&) [with _Tp = ThePEG::Qty<0, 0, 0>]':
AmplitudeBase.cc:587:70:   required from here
/build/cmsbld/jenkins/workspace/build-any-ib/w/slc7_amd64_gcc900/external/gcc/9.0.0-nmpfii/include/c++/9.1.1/complex:1319:19: error: 'const struct std::complex<ThePEG::Qty<0, 0, 0> >' has no member named '__rep'
 1319 |    _M_value = __z.__rep();
      |               ~~~~^~~~~
make[1]: *** [AmplitudeBase.lo] Error 1

smuzaffar · 2019-06-13T04:23:07Z

@fabiocos , @Andrej-CMS I am afraid we need to revert it back as it fails to build for GCC 9

fabiocos · 2019-06-13T08:02:54Z

@Andrej-CMS I think that the code developers/maintainers should be notified about this issue, adapting also the extensions to the previous fix.

Andrej-CMS added 2 commits March 6, 2019 08:16

added Hjets and VBFNLO to Herwig7

2f24f49

removed unnecessary lines

f6cf9b4

cmsbuild added externals-pending orp-pending pending-signatures tests-pending labels Mar 6, 2019

smuzaffar reviewed Mar 6, 2019

View reviewed changes

downloading form git

7caa456

cmsbuild added tests-started and removed tests-pending labels Mar 6, 2019

cmsbuild added tests-rejected and removed tests-started labels Mar 6, 2019

cmsbuild added tests-pending and removed tests-rejected labels Mar 12, 2019

cmsbuild added tests-started and removed tests-pending labels Mar 12, 2019

smuzaffar reviewed Mar 12, 2019

View reviewed changes

run autoreconf -vi before configure

0292057

cmsbuild added the tests-pending label May 20, 2019

cmsbuild added tests-started and removed tests-pending labels May 20, 2019

cmsbuild added tests-approved and removed tests-started labels May 20, 2019

cmsbuild added comparison-available and removed comparison-pending labels May 20, 2019

cmsbuild added externals-approved and removed externals-pending labels May 20, 2019

cmsbuild added fully-signed generators-approved and removed generators-pending pending-signatures labels May 21, 2019

cmsbuild added orp-approved and removed orp-pending labels May 21, 2019

cmsbuild merged commit ab68e84 into cms-sw:IB/CMSSW_11_0_X/gcc700 May 21, 2019

fabiocos mentioned this pull request Jun 13, 2019

Revert "adding VBFNLO and Hjets++ to the externals linked to Herwig7" #5038

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

adding VBFNLO and Hjets++ to the externals linked to Herwig7 #4753

adding VBFNLO and Hjets++ to the externals linked to Herwig7 #4753

Andrej-CMS commented Mar 6, 2019

cmsbuild commented Mar 6, 2019

smuzaffar Mar 6, 2019

Andrej-CMS Mar 7, 2019

Andrej-CMS Mar 11, 2019

smuzaffar Mar 12, 2019

smuzaffar commented Mar 6, 2019

cmsbuild commented Mar 6, 2019

Andrej-CMS commented Mar 6, 2019

smuzaffar commented Mar 6, 2019

Andrej-CMS commented Mar 6, 2019

smuzaffar commented Mar 6, 2019

cmsbuild commented Mar 6, 2019 •

edited

cmsbuild commented Mar 6, 2019

mrodozov commented Mar 12, 2019

cmsbuild commented Mar 12, 2019 •

edited

cmsbuild commented Mar 12, 2019

smuzaffar Mar 12, 2019 •

edited

cmsbuild commented May 20, 2019 •

edited

cmsbuild commented May 20, 2019

cmsbuild commented May 20, 2019

cmsbuild commented May 20, 2019

cmsbuild commented May 20, 2019

smuzaffar commented May 20, 2019

qliphy commented May 21, 2019

cmsbuild commented May 21, 2019

smuzaffar commented May 21, 2019

fabiocos commented May 21, 2019

smuzaffar commented Jun 6, 2019

smuzaffar commented Jun 13, 2019

fabiocos commented Jun 13, 2019

		@@ -0,0 +1,24 @@
		### RPM external vbfnlo 3.0.0beta5
		Source: http://www.itp.kit.edu/~vbfnloweb/archive/vbfnlo-%{realversion}.tgz

adding VBFNLO and Hjets++ to the externals linked to Herwig7 #4753

adding VBFNLO and Hjets++ to the externals linked to Herwig7 #4753

Conversation

Andrej-CMS commented Mar 6, 2019

cmsbuild commented Mar 6, 2019

smuzaffar Mar 6, 2019

Choose a reason for hiding this comment

Andrej-CMS Mar 7, 2019

Choose a reason for hiding this comment

Andrej-CMS Mar 11, 2019

Choose a reason for hiding this comment

smuzaffar Mar 12, 2019

Choose a reason for hiding this comment

smuzaffar commented Mar 6, 2019

cmsbuild commented Mar 6, 2019

Andrej-CMS commented Mar 6, 2019

smuzaffar commented Mar 6, 2019

Andrej-CMS commented Mar 6, 2019

smuzaffar commented Mar 6, 2019

cmsbuild commented Mar 6, 2019 • edited

cmsbuild commented Mar 6, 2019

mrodozov commented Mar 12, 2019

cmsbuild commented Mar 12, 2019 • edited

cmsbuild commented Mar 12, 2019

smuzaffar Mar 12, 2019 • edited

Choose a reason for hiding this comment

cmsbuild commented May 20, 2019 • edited

cmsbuild commented May 20, 2019

cmsbuild commented May 20, 2019

cmsbuild commented May 20, 2019

cmsbuild commented May 20, 2019

smuzaffar commented May 20, 2019

qliphy commented May 21, 2019

cmsbuild commented May 21, 2019

smuzaffar commented May 21, 2019

fabiocos commented May 21, 2019

smuzaffar commented Jun 6, 2019

smuzaffar commented Jun 13, 2019

fabiocos commented Jun 13, 2019

cmsbuild commented Mar 6, 2019 •

edited

cmsbuild commented Mar 12, 2019 •

edited

smuzaffar Mar 12, 2019 •

edited

cmsbuild commented May 20, 2019 •

edited