Update root 6-12

[mrodozov]

Get one commit on top of 6-12

[mrodozov]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33589/console

[cmsbuild]

A new Pull Request was created by @mrodozov (Mircho Rodozov) for branch IB/CMSSW_10_6_X/gcc700.

@cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

[cmsbuild]

-1

Tested at: fafe65a

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4783/33589/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

• Unit Tests:

I found errors in the following unit tests:

---> test materialBudgetTrackerPlots had ERRORS

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4783/33589/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 3114829
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3114631
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 133 log files, 14 edm output root files, 32 DQM output files

[smuzaffar]

+externals
@fabiocos , @slava77 , @ Dr15Jones, this PR adds on commit [a]. This was merged in root 6.14 and above a long time ago and now we have requested to include in 6.12 too. This is needed to move forward with GCC 7.4 and GCC 8.3. PR tests looks good. We have one unit test failing which is already failing in IBs. Comparison also looks good.

Any objections on integrating it in 10.6.X?

[a] root-project/root#3518
[IO] Do not loop over base classes of pair since it is an stl template
cms-sw/root@32b81d1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_10_6_X/gcc700 IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1

this does not look to solve the existing issue, but the tests do not show evidence for new problems as well