Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backporting sherpa2.2.6 and openloops2.0.0 to 71X #4821

Merged
merged 6 commits into from May 7, 2019

Conversation

SiewYan
Copy link
Contributor

@SiewYan SiewYan commented Mar 28, 2019

backporting sherpa2.2.6 and openloops2.0.0

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @SiewYan (SiewYan) for branch IB/CMSSW_7_1_X/stable.

@cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@SiewYan
Copy link
Contributor Author

SiewYan commented Mar 28, 2019

Hi, please apply the mentioned patches in [1] and [2] ,mentioned here [3]

[1] cms-externals/openloops@5141c0e
[2] https://gitlab.com/openloops/OpenLoops/commit/8ff8f52fe6e0f9f4f3f666b0d89279da64554fc3
[3] #4796

@SiewYan SiewYan changed the title backporting sherpa2.2.6 and openloops2.0.0 backporting sherpa2.2.6 and openloops2.0.0 to 71X Mar 28, 2019
@cmsbuild
Copy link
Contributor

Pull request #4821 was updated.

1 similar comment
@cmsbuild
Copy link
Contributor

Pull request #4821 was updated.

@cmsbuild
Copy link
Contributor

Pull request #4821 was updated.

Propagating changes in cms-sw#4796 
1.) Include proclib
2.) Process libraries generation
3.) changes openloops source by imitating gitlab tag hash
@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2019

Pull request #4821 was updated.

@SiewYan
Copy link
Contributor Author

SiewYan commented Apr 9, 2019

@mrodozov , could you please check the gitlab tag is correct and trigger the test?
Thanks.

@cmsbuild
Copy link
Contributor

Pull request #4821 was updated.

@mrodozov
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 30, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/34420/console

@cmsbuild
Copy link
Contributor

-1

Tested at: 1109319

  • Build:

I found compilation error when building:

result = func(*args)
File "/build/cmsbld/jenkins/workspace/ib-any-integration/testBuildDir/slc6_amd64_gcc481/external/python/2.7.6/lib/python2.7/urllib2.py", line 1222:
return self.do_open(httplib.HTTPSConnection, req)
File "/build/cmsbld/jenkins/workspace/ib-any-integration/testBuildDir/slc6_amd64_gcc481/external/python/2.7.6/lib/python2.7/urllib2.py", line 1184:
raise URLError(err)
error: Bad exit status from /build/cmsbld/jenkins/workspace/ib-any-integration/testBuildDir/tmp/rpm-tmp.EYxZ08 (%build)


RPM build errors:
Bad exit status from /build/cmsbld/jenkins/workspace/ib-any-integration/testBuildDir/tmp/rpm-tmp.EYxZ08 (%build)



You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4821/34420/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented May 3, 2019

Pull request #4821 was updated.

@mrodozov
Copy link
Contributor

mrodozov commented May 3, 2019

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 3, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/34471/console

@cmsbuild
Copy link
Contributor

cmsbuild commented May 3, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented May 3, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4821/34471/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 11
  • DQMHistoTests: Total histograms compared: 682535
  • DQMHistoTests: Total failures: 3314
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 678847
  • DQMHistoTests: Total skipped: 374
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -10 KiB( 10 files compared)
  • Checked 44 log files, 4 edm output root files, 11 DQM output files

@smuzaffar
Copy link
Contributor

thanks @mrodozov , can you please locally build it and compare the openloop install are to see if all the extra downloaded files are available there? Compare it with the slc7_amd64_gcc700 installation of openloops 2.0.0 on CVMFS to make sure this this workaround actually copied all the files.

@qliphy
Copy link
Contributor

qliphy commented May 4, 2019

@smuzaffar #4823 is now merged. Would you please trigger test this PR and move forward? Thanks!

@mrodozov
Copy link
Contributor

mrodozov commented May 4, 2019

The installation on cvmfs has three folders, etc lib and proclib , all the files present in the 481 installation are also present in /cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc700/external/openloops/2.0.0
the 481 installation is on cmsdev22
/build/mrodozov/build_sherpa_gcc4/build_openloops_localrepo/slc6_amd64_gcc481/external/openloops/2.0.0

@smuzaffar
Copy link
Contributor

+externals
thanks @mrodozov . @fabiocos this is ready to go in 71X now.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2019

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_7_1_X/stable IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented May 7, 2019

+1

@cmsbuild cmsbuild merged commit 0bed3e7 into cms-sw:IB/CMSSW_7_1_X/stable May 7, 2019
@SiewYan SiewYan deleted the backport-sherpa71X branch November 11, 2019 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants