Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backporting sherpa2.2.6 and openloops2.0.0 to 102X #4823

Merged
merged 10 commits into from May 2, 2019
Merged

Backporting sherpa2.2.6 and openloops2.0.0 to 102X #4823

merged 10 commits into from May 2, 2019

Conversation

SiewYan
Copy link
Contributor

@SiewYan SiewYan commented Mar 29, 2019

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @SiewYan (SiewYan) for branch IB/CMSSW_10_2_X/gcc700.

@cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@cmsbuild
Copy link
Contributor

Pull request #4823 was updated.

1 similar comment
@cmsbuild
Copy link
Contributor

Pull request #4823 was updated.

@cmsbuild
Copy link
Contributor

Pull request #4823 was updated.

@mrodozov
Copy link
Contributor

please test
lets try this

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 29, 2019 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33855/console

@cmsbuild
Copy link
Contributor

-1

Tested at: 510bc43

  • Build:

I found compilation error when building:

want to install GNU make:

make[1]: *** [Sherpa.info] Error 127
make[1]: Leaving directory `/build/cmsbld/jenkins/workspace/ib-any-integration/testBuildDir/BUILD/slc6_amd64_gcc700/external/sherpa/2.2.6/sherpa-2.2.6/Manual'
make: *** [install-recursive] Error 1
error: Bad exit status from /build/cmsbld/jenkins/workspace/ib-any-integration/testBuildDir/tmp/rpm-tmp.XndNAX (%install)


RPM build errors:
Bad exit status from /build/cmsbld/jenkins/workspace/ib-any-integration/testBuildDir/tmp/rpm-tmp.XndNAX (%install)

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4823/33855/summary.html

@mrodozov
Update sherpa.spec
f74ea1b 
There is an old bug mentioned here:
https://sourceware.org/bugzilla/show_bug.cgi?id=18113
we have a patch altering makefiles to pass around similar issue
We either apply similar patch or keep the hack linking makeinfo to true
@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 1, 2019

Pull request #4823 was updated.

@mrodozov
Copy link
Contributor

mrodozov commented Apr 1, 2019

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 1, 2019 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33868/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 1, 2019

-1

Tested at: f74ea1b

  • Build:

I found compilation error when building:

want to install GNU make:

make[1]: *** [Sherpa.info] Error 127
make[1]: Leaving directory `/build/cmsbld/jenkins/workspace/ib-any-integration/testBuildDir/BUILD/slc6_amd64_gcc700/external/sherpa/2.2.6/sherpa-2.2.6/Manual'
make: *** [install-recursive] Error 1
error: Bad exit status from /build/cmsbld/jenkins/workspace/ib-any-integration/testBuildDir/tmp/rpm-tmp.IQJeno (%install)


RPM build errors:
Bad exit status from /build/cmsbld/jenkins/workspace/ib-any-integration/testBuildDir/tmp/rpm-tmp.IQJeno (%install)

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4823/33868/summary.html

@qliphy
Copy link
Contributor

qliphy commented Apr 29, 2019

Adding @davidlange6 @fabiocos @kpedro88

There is an issue with this PR on "makeinfo". Please find below a summary from Siew Yan:

1.) Update/Upgrade sherpa and open loop:
a.) Upgrade sherpa to 2.2.6 in 106X [1] (COMPLETE)
b.) Update open loops-2.0.b to openloops-2.0.0 [2] (COMPLETE)

2.) Backporting:
a.) Backporting sherpa 2.2.6 and openloops2.0.0 to 71X [3] (PENDING)
b.) Backporting sherpa 2.2.6 and openloops2.0.0 to 93X [4] (PENDING)
c.) Backporting sherpa 2.2.6 and openloops2.0.0 to 102X [5] (FAIL)

Pertaining to the nature of the issue on backporting sherpa and openloop in 102X [5], the bot failed at creating a makefile prior to sherpa building, specifically [6] :

The action "build-external+sherpa+2.2.6" was not completed successfully because Failed to build sherpa. …

/build/cmsbld/jenkins/workspace/ib-any-integration/testBuildDir/BUILD/slc6_amd64_gcc700/external/sherpa/2.2.6/sherpa-2.2.6/missing: line 81: makeinfo: command not found

WARNING: 'makeinfo' is missing on your system.
You should only need it if you modified a '.texi' file, or
any other file indirectly affecting the aspect of the manual.
You might want to install the Texinfo package:
http://www.gnu.org/software/texinfo/
The spurious makeinfo call might also be the consequence of
using a buggy 'make' (AIX, DU, IRIX), in which case you might

In response to this, Mircho Rodozov came out with a patch to circumvent makeinfo check (locally), however the hack does not work in bot testing[7]. The issue occur strangely to me as sherpa built successfully in 106X unless the issue came from the cmssw release side.

[1] #4726
[2] #4796
[3] #4821
[4] #4822
[5] #4823
[6] https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4823/34340/cmsswtoolconf.log
[7] #4823 (comment)

@smuzaffar
Copy link
Contributor

smuzaffar commented Apr 30, 2019 •
edited

please test
For now we have disabled building Manual

@cmsbuild
Copy link
Contributor

Pull request #4823 was updated.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 30, 2019 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/34418/console

@cmsbuild
Copy link
Contributor

cmsbuild commented May 1, 2019

+1
Tested at: dbd5e0a
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4823/34418/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented May 1, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 1, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4823/34418/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 3007400
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3007208
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
  • Checked 129 log files, 14 edm output root files, 31 DQM output files

@fabiocos
Copy link
Contributor

fabiocos commented May 1, 2019

+1

@fabiocos
Copy link
Contributor

fabiocos commented May 2, 2019

@efeyazgan @qliphy from the discussion at the ORP meeting I understand that this update is not going to break physics compatibility with the current production version

@smuzaffar we may move forward with the integration, I doubt the makeinfo is relevant for our CMSSW purposes

@smuzaffar
Copy link
Contributor

+externals

@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2019

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_10_2_X/gcc700 IBs (tests are also fine). This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit f170318 into cms-sw:IB/CMSSW_10_2_X/gcc700 May 2, 2019
This was referenced May 4, 2019
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available externals-approved fully-signed orp-approved tests-approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@SiewYan @cmsbuild @mrodozov @qliphy @smuzaffar @fabiocos