Move llvm to 8.0.1 as llvm-lite was updated to 0.29

[cmsbuild]

backport of #5114

[cmsbuild]

A new Pull Request was created by @cmsbuild for branch IB/CMSSW_11_0_X/gcc700.

@cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

• Backported from Move llvm to 8.0.1 as llvm-lite was updated to 0.29 #5114

[smuzaffar]

please test with cms-sw/cmssw#27663 for CMSSW_11_0_CLANG_X

[cmsbuild]

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmssw#27663
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1934/console Started: 2019/08/09 12:40

[cmsbuild]

-1

Tested at: 6693a07

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b8a5cb/1934/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

• Unit Tests:

I found errors in the following unit tests:

---> test test_MpsWorkFlow had ERRORS
---> test DD4hepGeometryTestDriver had ERRORS
---> test testDD4hepFilteredView had ERRORS
---> test testDD4hepCompactView had ERRORS
---> test testDD4hepExpandedView had ERRORS
---> test DetectorDescriptionDDCMSTestDriver had ERRORS
---> test runtestTqafTopJetCombination had ERRORS
---> test runtestTqafTopEventSelection had ERRORS

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b8a5cb/1934/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 11821 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2939508
• DQMHistoTests: Total failures: 31750
• DQMHistoTests: Total nulls: 4
• DQMHistoTests: Total successes: 2907413
• DQMHistoTests: Total skipped: 341
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.008 KiB( 33 files compared)
• DQMHistoSizes: changed ( 4.53,... ): 0.004 KiB JetMET/SUSYDQM
• Checked 142 log files, 14 edm output root files, 34 DQM output files

[mrodozov]

please test

[cmsbuild]

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmssw#27877
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2204/console Started: 2019/08/27 09:19

[davidlange6]

the differences are in log errors for one workflow https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_11_0_X_2019-08-26-1100+b8a5cb/33241/validateJR/all_OldVSNew_TTbar13TeVPU2017wf10224p0/ 14 fileAction -s MixingModule:mix 3 3 15 fileAction -s MixingModule:mix 2 2 16 fileAction -s MixingModule:mix 1 1 vs 14 fileAction -s MixingModule:mix 2 2 15 fileAction -s MixingModule:mix 1 1 (which I don't see in the log itself...) do we understand this btw 26-Aug-2019 13:01:22 CEST Successfully opened file root://eoscms.cern.ch//eos/cms/store/user/cmsbuild/store/relval/CMSSW_10_6_0/RelValMinBias_13/GEN-SIM/106X_mc2017_realistic_v3-v1/10000/5F6D4D28-A5D2-6A48-B327-5C827D7F53FB.root [13:01:28] /build/cmsbld/jenkins/workspace/build-any-ib/w/BUILD/slc7_amd64_gcc700/external/mxnet-predict/1.5.0/mxnet-predict-1.5.0/src/nnvm/legacy_json_util.cc:209: Loading symbol saved by previous version v1.2.1. Attempting to upgrade... [13:01:28] /build/cmsbld/jenkins/workspace/build-any-ib/w/BUILD/slc7_amd64_gcc700/external/mxnet-predict/1.5.0/mxnet-predict-1.5.0/src/nnvm/legacy_json_util.cc:217: Symbol successfully upgraded! [13:01:29] /build/cmsbld/jenkins/workspace/build-any-ib/w/BUILD/slc7_amd64_gcc700/external/mxnet-predict/1.5.0/mxnet-predict-1.5.0/src/nnvm/legacy_json_util.cc:209: Loading symbol saved by previous version v1.2.1. Attempting to upgrade... [13:01:29] /build/cmsbld/jenkins/workspace/build-any-ib/w/BUILD/slc7_amd64_gcc700/external/mxnet-predict/1.5.0/mxnet-predict-1.5.0/src/nnvm/legacy_json_util.cc:217: Symbol successfully upgraded!

…

On Aug 27, 2019, at 9:11 AM, Malik Shahzad Muzaffar ***@***.***> wrote: +externals @slava77 , can you please check the reco comparison results here? Do they look real to you? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

[smuzaffar]

@davidlange6, looks like this is due to file /cvmfs/cms-ib.cern.ch/nweek-02591/slc7_amd64_gcc700/cms/cmssw/CMSSW_11_0_X_2019-08-26-2300/external/slc7_amd64_gcc700/data/RecoBTag/Combined/data/DeepBoostedJet/V02/full/resnet-symbol.json which was created with "mxnet_version": ["int", 10201] and now we have mxnet verison 1.5.0.

[cmsbuild]

+1
Tested at: 6693a07
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8612c8/2204/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• #27837 @mrodozov: Fix gcc9 warnings in CalibCalorimetry/EcalCorrelatedNoiseAnalysisAlgos
• #27830 @bsunanda: Run3-alca158 Update the analysis macros for MIP monitoring of HE RadDam
• #27672 @dilsonjd: Complete the implementation of RPC Digi Collection Merger started in PR #24613
• #27832 @dildick: Update GEMPadDigi clustering procedure
• #27848 @ianna: Remove DD Dependency
• #27799 @mrodozov: Fix warnings for gcc9 in DQMServices/Core
• #27811 @mrodozov: Fix gcc 9 warnings DQM/DTMonitorClient - Add fallthroughs to clear the warnings
• #27829 @bsunanda: Run3-TB44 Update the usage of TB beam generator
• #27834 @mrodozov: Fix gcc9 warnings in GeneratorInterface
• #27825 @mrodozov: Fix gcc9 warnings Alignment/MillePedeAlignmentAlgorithm
• #27840 @mrodozov: Fix gcc9 warnings in Calibration
• #27838 @mrodozov: Fix gcc9 warnings in Alignment
• #27439 @amartelli: HGCAL TICL seeded iteration
• #27845 @mrodozov: Fix warnings for gcc9 in DQM

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8612c8/2204/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8612c8/2204/git-merge-result

[cmsbuild]

Comparison job queued.

[davidlange6]

can we get rid of the warnings somehow?

…

On Aug 27, 2019, at 11:20 AM, Malik Shahzad Muzaffar ***@***.***> wrote: @davidlange6, looks like this is due to file /cvmfs/cms-ib.cern.ch/nweek-02591/slc7_amd64_gcc700/cms/cmssw/CMSSW_11_0_X_2019-08-26-2300/external/slc7_amd64_gcc700/data/RecoBTag/Combined/data/DeepBoostedJet/V02/full/resnet-symbol.json which was created with "mxnet_version": ["int", 10201] and now we have mxnet verison 1.5.0. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8612c8/2204/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2939508
• DQMHistoTests: Total failures: 5
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2939162
• DQMHistoTests: Total skipped: 341
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 145 log files, 15 edm output root files, 34 DQM output files

[smuzaffar]

FYI @fabiocos , @davidlange6 , @kpedro88 and @Dr15Jones
Here are the results of clang-format and clang-tidy running on full cmssw using current LLVM 7 and new LLVM 8.0.1

• LLVM 7

  • clang-format: Total files still need formating are 28
    • https://cmssdt.cern.ch/SDT/jenkins-artifacts/jenkins-test-code-format/CMSSW_11_0_X_2019-08-27-2300/30/code-format.txt
    • https://cmssdt.cern.ch/SDT/jenkins-artifacts/jenkins-test-code-format/CMSSW_11_0_X_2019-08-27-2300/30/code-format.patch
  • clang-tidy: Total files still need clang-tidy fixes are 18
    • https://cmssdt.cern.ch/SDT/jenkins-artifacts/jenkins-test-code-format/CMSSW_11_0_X_2019-08-27-2300/30/code-checks.txt
  • https://cmssdt.cern.ch/SDT/jenkins-artifacts/jenkins-test-code-format/CMSSW_11_0_X_2019-08-27-2300/30/code-checks.patch

• LLVM 8.0.1

  • clang-format: Total files still need formating are 60
    • https://cmssdt.cern.ch/SDT/jenkins-artifacts/jenkins-test-code-format/CMSSW_11_0_DEVEL_X_2019-08-26-2300/29/code-format.txt
    • https://cmssdt.cern.ch/SDT/jenkins-artifacts/jenkins-test-code-format/CMSSW_11_0_DEVEL_X_2019-08-26-2300/29/code-format.patch
  • clang-tidy: Total files still need clang-tidy fixes are 21
    • https://cmssdt.cern.ch/SDT/jenkins-artifacts/jenkins-test-code-format/CMSSW_11_0_DEVEL_X_2019-08-26-2300/29/code-checks.txt
    • https://cmssdt.cern.ch/SDT/jenkins-artifacts/jenkins-test-code-format/CMSSW_11_0_DEVEL_X_2019-08-26-2300/29/code-checks.patch

I would suggest to go ahead with llvm 8.0.1 integration in master branch.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_11_0_X/gcc700 IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[kpedro88]

+1