Add onnxruntime python package #5668

mrodozov · 2020-03-18T23:34:46Z

please test
add also libpng and zlib for onnxruntime, it was picking the system one.
py3-onnxruntime creates a wheel that results in only lib/python3.6/site-packages/
looks safe to be used

cmsbuild · 2020-03-18T23:35:06Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5265/console Started: 2020/03/19 00:37

cmsbuild · 2020-03-18T23:35:07Z

A new Pull Request was created by @mrodozov (Mircho Rodozov) for branch IB/CMSSW_11_1_X/master.

@cmsbuild, @smuzaffar, @mrodozov, @tulamor can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

cmsbuild · 2020-03-19T01:09:22Z

+1
Tested at: 51c503d
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a5a3ea/5265/summary.html
CMSSW: CMSSW_11_1_X_2020-03-18-1100
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-03-19T01:09:25Z

Comparison job queued.

cmsbuild · 2020-03-19T02:36:55Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a5a3ea/5265/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 34
DQMHistoTests: Total histograms compared: 2692437
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2692117
DQMHistoTests: Total skipped: 319
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
Checked 147 log files, 16 edm output root files, 34 DQM output files

smuzaffar · 2020-03-19T08:36:23Z

pip/requirements.txt

@@ -127,6 +128,7 @@ more-itertools==5.0.0 ; python_version<'3.0'
 more-itertools==7.2.0 ; python_version>'3.0'
 mpld3==0.3
 mpmath==1.1.0
+mxnet==1.6.0


do we need this?

I though I removed this

smuzaffar · 2020-03-19T08:36:30Z

pip/requirements.txt

@@ -75,6 +75,7 @@ GitPython==2.1.15 ; python_version<'3.0'
 GitPython==3.0.4 ; python_version>'3.0'
 google-common==0.0.1
 google-pasta==0.1.8
+graphviz==0.13.2


this one yes, it complained it needs it

it might be needed for mxnet, as I do not see this as a dependency in onnxruntime.file

it wasn't , its also remnant from the mxnet pip requirements

smuzaffar · 2020-03-19T08:37:26Z

pip/requirements.txt

@@ -146,6 +148,7 @@ numpy==1.15.1 ; python_version<'3.0' ; platform_machine=='aarch64'
 numpy==1.15.1 ; python_version>'3.0' ; platform_machine=='aarch64'
 oamap==0.12.4
 onnx==1.6.0
+onnxruntime==1.2.0 ; python_version>'3.0'


shouldn't we also update python_tools.spec (only for non-ppc64 )

cmsbuild · 2020-03-19T10:33:44Z

Pull request #5668 was updated.

cmsbuild · 2020-03-19T15:49:47Z

Pull request #5668 was updated.

smuzaffar · 2020-03-19T15:50:00Z

pleae test

mrodozov · 2020-03-19T15:52:01Z

please test

cmsbuild · 2020-03-19T17:54:17Z

+1
Tested at: c8c1f37
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a5a3ea/5275/summary.html
CMSSW: CMSSW_11_1_X_2020-03-18-2300
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-03-19T17:54:20Z

Comparison job queued.

smuzaffar · 2020-03-19T17:57:08Z

@mrodozov , can you please also add some unit tests for onnxruntime python?

cmsbuild · 2020-03-19T19:28:23Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a5a3ea/5275/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 6 differences found in the comparisons
DQMHistoTests: Total files compared: 34
DQMHistoTests: Total histograms compared: 2692437
DQMHistoTests: Total failures: 46
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2692072
DQMHistoTests: Total skipped: 319
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
Checked 147 log files, 16 edm output root files, 34 DQM output files

cmsbuild · 2020-03-19T21:45:37Z

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmssw#29246
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5281/console Started: 2020/03/19 23:15

smuzaffar · 2020-03-19T21:55:03Z

+externals

cmsbuild · 2020-03-19T21:55:22Z

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_11_1_X/master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

cmsbuild · 2020-03-20T00:15:35Z

+1
Tested at: c8c1f37
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e67ad8/5281/summary.html
CMSSW: CMSSW_11_1_X_2020-03-19-1100
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-03-20T00:15:39Z

Comparison job queued.

cmsbuild · 2020-03-20T01:48:57Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e67ad8/5281/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 34
DQMHistoTests: Total histograms compared: 2692493
DQMHistoTests: Total failures: 24
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2692150
DQMHistoTests: Total skipped: 319
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
Checked 147 log files, 16 edm output root files, 34 DQM output files

Add onnxruntime python package

51c503d

cmsbuild added comparison-pending externals-pending orp-pending pending-signatures tests-pending labels Mar 18, 2020

cmsbuild added tests-started and removed tests-pending labels Mar 18, 2020

cmsbuild added tests-approved and removed tests-started labels Mar 19, 2020

cmsbuild added comparison-available and removed comparison-pending labels Mar 19, 2020

smuzaffar reviewed Mar 19, 2020

View reviewed changes

remove mxnet pip requirements and add py3onnxrt to py tools

48b2d18

cmsbuild added comparison-pending tests-pending and removed comparison-available tests-approved labels Mar 19, 2020

python3 is a requirement and should come via py3 packages

c8c1f37

cmsbuild added tests-approved and removed tests-started labels Mar 19, 2020

cmsbuild added comparison-available and removed comparison-pending labels Mar 19, 2020

mrodozov mentioned this pull request Mar 19, 2020

Add ONNXruntime python test cms-sw/cmssw#29246

Merged

cmsbuild added requires-external tests-started and removed tests-approved labels Mar 19, 2020

smuzaffar merged commit 9c98ec6 into IB/CMSSW_11_1_X/master Mar 19, 2020

cmsbuild added externals-approved fully-signed and removed externals-pending pending-signatures labels Mar 19, 2020

cmsbuild added comparison-pending tests-approved and removed comparison-available tests-started labels Mar 20, 2020

cmsbuild added comparison-available and removed comparison-pending labels Mar 20, 2020

smuzaffar deleted the onnxrt-python-pkg branch March 20, 2020 09:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add onnxruntime python package #5668

Add onnxruntime python package #5668

mrodozov commented Mar 18, 2020

cmsbuild commented Mar 18, 2020 •

edited

cmsbuild commented Mar 18, 2020

cmsbuild commented Mar 19, 2020

cmsbuild commented Mar 19, 2020

cmsbuild commented Mar 19, 2020

smuzaffar Mar 19, 2020

mrodozov Mar 19, 2020

smuzaffar Mar 19, 2020

mrodozov Mar 19, 2020

smuzaffar Mar 19, 2020

mrodozov Mar 19, 2020

smuzaffar Mar 19, 2020

cmsbuild commented Mar 19, 2020

cmsbuild commented Mar 19, 2020

smuzaffar commented Mar 19, 2020

mrodozov commented Mar 19, 2020

cmsbuild commented Mar 19, 2020

cmsbuild commented Mar 19, 2020

smuzaffar commented Mar 19, 2020

cmsbuild commented Mar 19, 2020

cmsbuild commented Mar 19, 2020 •

edited

smuzaffar commented Mar 19, 2020

cmsbuild commented Mar 19, 2020

cmsbuild commented Mar 20, 2020

cmsbuild commented Mar 20, 2020

cmsbuild commented Mar 20, 2020

Add onnxruntime python package #5668

Add onnxruntime python package #5668

Conversation

mrodozov commented Mar 18, 2020

cmsbuild commented Mar 18, 2020 • edited

cmsbuild commented Mar 18, 2020

cmsbuild commented Mar 19, 2020

cmsbuild commented Mar 19, 2020

cmsbuild commented Mar 19, 2020

smuzaffar Mar 19, 2020

Choose a reason for hiding this comment

mrodozov Mar 19, 2020

Choose a reason for hiding this comment

smuzaffar Mar 19, 2020

Choose a reason for hiding this comment

mrodozov Mar 19, 2020

Choose a reason for hiding this comment

smuzaffar Mar 19, 2020

Choose a reason for hiding this comment

mrodozov Mar 19, 2020

Choose a reason for hiding this comment

smuzaffar Mar 19, 2020

Choose a reason for hiding this comment

cmsbuild commented Mar 19, 2020

cmsbuild commented Mar 19, 2020

smuzaffar commented Mar 19, 2020

mrodozov commented Mar 19, 2020

cmsbuild commented Mar 19, 2020

cmsbuild commented Mar 19, 2020

smuzaffar commented Mar 19, 2020

cmsbuild commented Mar 19, 2020

cmsbuild commented Mar 19, 2020 • edited

smuzaffar commented Mar 19, 2020

cmsbuild commented Mar 19, 2020

cmsbuild commented Mar 20, 2020

cmsbuild commented Mar 20, 2020

cmsbuild commented Mar 20, 2020

cmsbuild commented Mar 18, 2020 •

edited

cmsbuild commented Mar 19, 2020 •

edited