Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OnnxRuntime: enable python bindings #5675

Merged
merged 2 commits into from Mar 20, 2020

Conversation

smuzaffar
Copy link
Contributor

  • Enable python bindings
  • Due to bug in onnxruntime build, we need to enable unit tests to get the python build
  • Use lib instead of lib64 so that shared lib and python bindings live in same path

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_11_1_X/master.

@cmsbuild, @smuzaffar, @mrodozov, @tulamor can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

@smuzaffar
Copy link
Contributor Author

please test with cms-sw/cmssw#29246

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 20, 2020

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmssw#29246
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5287/console Started: 2020/03/20 13:04
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5288/console Started: 2020/03/20 13:05

@cmsbuild
Copy link
Contributor

Pull request #5675 was updated.

@smuzaffar smuzaffar changed the title enable python bindings OnnxRuntime: enable python bindings Mar 20, 2020
@mrodozov
Copy link
Contributor

I tried to build it with enabling the flag, it didn't build anything new, that's why I decide to do it with the pip package, did it worked ?

@mrodozov
Copy link
Contributor

* Enable python bindings

* Due to bug in onnxruntime build, we need to enable unit tests to get the python build

* Use `lib` instead of lib64 so that shared lib and python bindings live in same path

ah ok then

@smuzaffar
Copy link
Contributor Author

yes it worked on aarch64

@mrodozov
Copy link
Contributor

please test with cms-sw/cmssw#29246

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 20, 2020

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmssw#29246
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5291/console Started: 2020/03/20 15:00

@cmsbuild
Copy link
Contributor

+1
Tested at: 4ef9f90
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-613354/5291/summary.html
CMSSW: CMSSW_11_1_X_2020-03-19-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@smuzaffar
Copy link
Contributor Author

+externals

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_11_1_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@smuzaffar smuzaffar merged commit 246da9c into IB/CMSSW_11_1_X/master Mar 20, 2020
@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-613354/5291/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2692493
  • DQMHistoTests: Total failures: 35
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2692139
  • DQMHistoTests: Total skipped: 319
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants