Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[10.6.X] apply RecoBTag-Combined=V01-03-00 for 106X #5717

Merged
merged 1 commit into from Apr 8, 2020
Merged

[10.6.X] apply RecoBTag-Combined=V01-03-00 for 106X #5717

merged 1 commit into from Apr 8, 2020

Conversation

slava77
Copy link
Contributor

@slava77 slava77 commented Apr 4, 2020

The initial goal here is to propagate cms-data/RecoBTag-Combined#24 and cms-data/RecoBTag-Combined#26.
However, all changes since 106X, in addition to what is needed to be backported are pure additions cms-data/RecoBTag-Combined@V01-01-04...V01-03-00
A more targeted backport will require making a new branch and out-of-order tag for cms-data/RecoBTag-Combined repo.

So, for 10_6_X, I think that it's more practical to just pick the current master version

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2020

A new Pull Request was created by @slava77 (Slava Krutelyov) for branch IB/CMSSW_10_6_X/gcc700.

@cmsbuild, @smuzaffar, @mrodozov, @tulamor can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

@slava77
Copy link
Contributor Author

slava77 commented Apr 4, 2020

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2020 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5531/console Started: 2020/04/04 18:21

@slava77 slava77 mentioned this pull request Apr 4, 2020
Merged
@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2020

+1
Tested at: 4f087f7
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e87d8c/5531/summary.html
CMSSW: CMSSW_10_6_X_2020-04-04-1100
SCRAM_ARCH: slc7_amd64_gcc700

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e87d8c/5531/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3212324
  • DQMHistoTests: Total failures: 20
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3211970
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@slava77
Copy link
Contributor Author

slava77 commented Apr 4, 2020

  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total failures: 20

these are all apparently random, not related to this PR.

Note that either #5592 or #5718 (both merged by now) now should trigger a warning about older version of MXNet file, which is fixed in cms-data/RecoBTag-Combined#24 , which is a part of this PR update.

@smuzaffar please check and sign when you have a chance.
Next step would be to add it to the release.

@smuzaffar
Copy link
Contributor

+externals

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 5, 2020

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_10_6_X/gcc700 IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

@smuzaffar
Copy link
Contributor

@slava77 , can this be safely merged without cms-sw/cmssw#29062

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 7, 2020 •
edited

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmssw#29062
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5569/console Started: 2020/04/07 18:44

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 7, 2020

+1
Tested at: 4f087f7
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-84e2b8/5569/summary.html
CMSSW: CMSSW_10_6_X_2020-04-07-1100
SCRAM_ARCH: slc7_amd64_gcc700

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 7, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 7, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-84e2b8/5569/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3212324
  • DQMHistoTests: Total failures: 31
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3211959
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 23a528a into cms-sw:IB/CMSSW_10_6_X/gcc700 Apr 8, 2020
@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmssw#29062

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 15, 2020 •
edited

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmssw#29062
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5702/console Started: 2020/04/15 15:10

@cmsbuild
Copy link
Contributor

+1
Tested at: 4f087f7
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-84e2b8/5702/summary.html
CMSSW: CMSSW_10_6_X_2020-04-15-1100
SCRAM_ARCH: slc7_amd64_gcc700

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-84e2b8/5702/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3212324
  • DQMHistoTests: Total failures: 43
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3211947
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available externals-approved fully-signed orp-approved requires-external tests-approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@slava77 @cmsbuild @smuzaffar @silviodonato