Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10_6_X] MXNet-based implementation of the ParticleNet tagger #29062

Merged
merged 4 commits into from Apr 18, 2020

Conversation

hqucms
Copy link
Contributor

@hqucms hqucms commented Feb 29, 2020

Backport of #28902.

Currently the ParticleNet tagger is not added to the MiniAOD sequence. But we plan to enable it for UL re-MiniAOD.

Needs:

We should also integrate cms-data/RecoBTag-Combined#24 together with the update to MXNet 1.5.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @hqucms (Huilin Qu) for CMSSW_10_6_X.

It involves the following packages:

PhysicsTools/PatAlgos
RecoBTag/Configuration
RecoBTag/FeatureTools
RecoBTag/MXNet

@perrotta, @cmsbuild, @santocch, @slava77 can you please review it and eventually sign? Thanks.
@rappoccio, @gouskos, @hatakeyamak, @emilbols, @peruzzim, @seemasharmafnal, @mmarionncern, @ahinzmann, @smoortga, @jdolen, @ferencek, @jdamgov, @nhanvtran, @gkasieczka, @schoef, @andrzejnovak, @clelange, @riga, @JyothsnaKomaragiri, @mverzett, @gpetruc, @mariadalfonso this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2020

Pull request #29062 was updated. @perrotta, @cmsbuild, @santocch, @slava77 can you please check and sign again.

@slava77
Copy link
Contributor

slava77 commented Apr 4, 2020

test parameters

@slava77
Copy link
Contributor

slava77 commented Apr 4, 2020

Currently the ParticleNet tagger is not added to the MiniAOD sequence. But we plan to enable it for UL re-MiniAOD.

if this is planned for UL, please add the tagger via run2_miniAOD_devel

@slava77
Copy link
Contributor

slava77 commented Apr 7, 2020

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 7, 2020

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmsdist#5717
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5569/console Started: 2020/04/07 18:44

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 7, 2020

+1
Tested at: 7af0d67
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-84e2b8/5569/summary.html
CMSSW: CMSSW_10_6_X_2020-04-07-1100
SCRAM_ARCH: slc7_amd64_gcc700

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 7, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 7, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-84e2b8/5569/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3212324
  • DQMHistoTests: Total failures: 31
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3211959
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@santocch
Copy link

santocch commented Apr 8, 2020

+1

@slava77
Copy link
Contributor

slava77 commented Apr 15, 2020

test parameters

  • pull_request =

@slava77
Copy link
Contributor

slava77 commented Apr 15, 2020

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 15, 2020

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmsdist#5717
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5702/console Started: 2020/04/15 15:10

@slava77
Copy link
Contributor

slava77 commented Apr 15, 2020

Tested with other pull request(s) cms-sw/cmsdist#5717

@smuzaffar I thought that doing as in #29062 (comment) I would get the extra requirements reset.

test parameters

* pull_request =

What it the right way to reset the extras?

@cmsbuild
Copy link
Contributor

+1
Tested at: d6a8740
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-84e2b8/5702/summary.html
CMSSW: CMSSW_10_6_X_2020-04-15-1100
SCRAM_ARCH: slc7_amd64_gcc700

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-84e2b8/5702/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3212324
  • DQMHistoTests: Total failures: 43
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3211947
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@slava77
Copy link
Contributor

slava77 commented Apr 15, 2020

+1

for #29062 d6a8740

  • code changes are in line with the PR description and the follow up review. The backport is a bit closer to the master version than the 10_2_X, but it's still fairly close to the [10_2_X] MXNet-based implementation of the ParticleNet tagger #29063 .
    • The new code is enabled with run2_miniAOD_devel and otherwise does not affect the production workflows.
  • jenkins tests pass and comparisons with the baseline show no (relevant) differences
  • I checked locally with run2_miniAOD_devel added to wfs 1325.7 and 136.8311 to confirm that the particleNet taggers run and that the values are consistent with the tagger results in the master version (on 1000 events there were no differences above 1E-4 level relative, compared to the tag results in 11_1_0_pre5; I'm taking this as close enough for a validation for physics purpose as well).

@silviodonato
Copy link
Contributor

do you have comments @santocch?

@santocch
Copy link

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants