Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend jmalloc to monitor the peak memory usage of each thread (11.2.x) #5852

Merged
merged 2 commits into from May 30, 2020
Merged

Extend jmalloc to monitor the peak memory usage of each thread (11.2.x) #5852

merged 2 commits into from May 30, 2020

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented May 24, 2020

See jemalloc/jemalloc#1176 and jemalloc/jemalloc#1850 for the discussion with the jemalloc development team.

@fwyzard fwyzard mentioned this pull request May 24, 2020
Merged
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fwyzard (Andrea Bocci) for branch IB/CMSSW_11_2_X/master.

@cmsbuild, @smuzaffar, @mrodozov, @tulamor can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

@fwyzard
Copy link
Contributor Author

fwyzard commented May 24, 2020

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 24, 2020 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6548/console Started: 2020/05/24 11:32

@cmsbuild
Copy link
Contributor

+1
Tested at: 8b28d8d
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0412ff/6548/summary.html
CMSSW: CMSSW_11_2_X_2020-05-23-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0412ff/6548/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2780792
  • DQMHistoTests: Total failures: 44
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2780698
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
  • Checked 152 log files, 16 edm output root files, 36 DQM output files

makortel
makortel reviewed May 25, 2020
View reviewed changes
jemalloc.spec Outdated
%define branch master
%define github_user jemalloc
%define branch 52x-peakmem
%define github_user fwyzard
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we go with the patch, we should probably fork jemalloc under https://github.com/cms-externals/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure - this is just a way to show what the changes would be, and make sure it doesn't break anything in CMSSW.

@fwyzard fwyzard mentioned this pull request May 25, 2020
Merged
@cmsbuild
Copy link
Contributor

cmsbuild commented May 25, 2020 •
edited

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmssw#29970
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6575/console Started: 2020/05/25 20:17

@cmsbuild
Copy link
Contributor

+1
Tested at: 8b28d8d
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b50415/6575/summary.html
CMSSW: CMSSW_11_2_X_2020-05-25-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b50415/6575/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2780792
  • DQMHistoTests: Total failures: 17
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2780725
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
  • Checked 152 log files, 16 edm output root files, 36 DQM output files

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 30, 2020 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6705/console Started: 2020/05/30 11:00

@cmsbuild
Copy link
Contributor

Pull request #5852 was updated.

@cmsbuild
Copy link
Contributor

+1
Tested at: c327274
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0412ff/6705/summary.html
CMSSW: CMSSW_11_2_X_2020-05-29-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0412ff/6705/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2780792
  • DQMHistoTests: Total failures: 48
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2780694
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
  • Checked 152 log files, 16 edm output root files, 36 DQM output files

@smuzaffar
Copy link
Contributor

+externals

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_11_2_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

@smuzaffar smuzaffar merged commit 0cfdb7b into cms-sw:IB/CMSSW_11_2_X/master May 30, 2020
@smuzaffar smuzaffar mentioned this pull request Jun 2, 2020
Merged
@fwyzard fwyzard deleted the jemalloc_peak_memory_112x branch July 28, 2020 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makortel makortel makortel left review comments

Assignees
No one assigned
Labels
comparison-available externals-approved fully-signed orp-pending tests-approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fwyzard @cmsbuild @smuzaffar @makortel