Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.1.X] update L1Trigger-L1THGCal V01-02-00 #5991

Merged
merged 1 commit into from Jun 29, 2020

Conversation

smuzaffar
Copy link
Contributor

backport of #5982

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 25, 2020

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_11_1_X/master.

@cmsbuild, @smuzaffar, @mrodozov, @tulamor can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 25, 2020

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmssw#30355

@cmsbuild
Copy link
Contributor

+1
Tested at: 13bbf97
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7ab77b/7346/summary.html
CMSSW: CMSSW_11_1_X_2020-06-25-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7ab77b/7346/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2780792
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2780740
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
  • Checked 152 log files, 16 edm output root files, 36 DQM output files

@silviodonato
Copy link
Contributor

@smuzaffar can we merge this with cms-sw/cmssw#30355 ?

@smuzaffar
Copy link
Contributor Author

+externals

@smuzaffar
Copy link
Contributor Author

yes @silviodonato

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_11_1_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 86fa5b0 into IB/CMSSW_11_1_X/master Jun 29, 2020
@smuzaffar smuzaffar deleted the smuzaffar-patch-13 branch July 1, 2020 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants