Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport HGC trigger] V10/V11 e/g ID + calibration and concentrator module sums #30355

Merged
merged 6 commits into from Jun 29, 2020
Merged

[Backport HGC trigger] V10/V11 e/g ID + calibration and concentrator module sums #30355

merged 6 commits into from Jun 29, 2020

Conversation

jbsauvan
Copy link
Contributor

PR description:

  • Add e/gamma identification BDT and e/gamma energy corrections for the V10 and V11 geometries (@cerminar )
  • Implement module sums of unselected trigger cells in the concentrator (@echapon )

Backport of #30289

cerminar and others added 6 commits June 24, 2020 09:47
@cerminar @jbsauvan
new working points for EG ID in v10
f999bc0
@cerminar @jbsauvan
explicitly add v11 version of the ID
8139fc6
@cerminar @jbsauvan
calibrate the EM interpretaion for v10 and v11
0ba2227
@echapon @jbsauvan
add module sums to output of HGCalProcessorBase
aab47ca 
first implementation of module sums

use module ID and position

remove deprecated comment

add ntuple for TriggerSums, fill mipPt and pos

remove wafer u/v and sim energy

applied code-format and code-checks

Implement JBS's comments

second round of JBS comments
@cerminar @jbsauvan
refine calibration for EM interpretation in V9, V10 and V11 HGC geome…
097c134 
…tries
@jbsauvan
comments cms-sw#30289
d9a75ea
@cmsbuild cmsbuild added this to the CMSSW_11_1_X milestone Jun 24, 2020
@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 24, 2020 •
edited

A new Pull Request was created by @jbsauvan (Jean-Baptiste Sauvan) for CMSSW_11_1_X.

It involves the following packages:

L1Trigger/L1THGCal
L1Trigger/L1THGCalUtilities

@cmsbuild, @rekovic, @benkrikler, @kpedro88 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @amarini, @lgray this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@jbsauvan jbsauvan mentioned this pull request Jun 24, 2020
Merged
@silviodonato
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 24, 2020 •
edited

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

-1

Tested at: d9a75ea

CMSSW: CMSSW_11_1_X_2020-06-23-2300
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-00cd55/7310/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

  • RelVals:

When I ran the RelVals I found an error in the following workflows:
20434.0 step2

runTheMatrix-results/20434.0_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D41_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D41+RecoFullGlobal_2026D41+HARVESTFullGlobal_2026D41/step2_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D41_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D41+RecoFullGlobal_2026D41+HARVESTFullGlobal_2026D41.log
23234.0 step2 
runTheMatrix-results/23234.0_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D49_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D49+RecoFullGlobal_2026D49+HARVESTFullGlobal_2026D49/step2_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D49_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D49+RecoFullGlobal_2026D49+HARVESTFullGlobal_2026D49.log

@cmsbuild
Copy link
Contributor

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

@jbsauvan
Copy link
Contributor Author

Somehow it didn't find in the tests the data added in cms-data/L1Trigger-L1THGCal#18

@kpedro88
Copy link
Contributor

@smuzaffar @mrodozov
cms-sw/cmsdist#5982 needs to be backported to the 11_1_X branch of cmsdist

@smuzaffar
Copy link
Contributor

@kpedro88 , cms-sw/cmsdist#5991 backport the changes for 11.1.X

@silviodonato
Copy link
Contributor

please test with cms-sw/cmsdist#5991

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 25, 2020 •
edited

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmsdist#5991

@cmsbuild cmsbuild mentioned this pull request Jun 25, 2020
Merged
@cmsbuild
Copy link
Contributor

+1
Tested at: d9a75ea
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7ab77b/7346/summary.html
CMSSW: CMSSW_11_1_X_2020-06-25-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@kpedro88
Copy link
Contributor

backport of #30289

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7ab77b/7346/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2780792
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2780740
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
  • Checked 152 log files, 16 edm output root files, 36 DQM output files

@kpedro88
Copy link
Contributor

+upgrade

@silviodonato
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 905599d into cms-sw:CMSSW_11_1_X Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport-ok comparison-available l1-pending orp-approved pending-signatures requires-external tests-approved upgrade-approved
Projects
None yet
Milestone
CMSSW_11_1_X
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@jbsauvan @cmsbuild @silviodonato @kpedro88 @smuzaffar @cerminar @echapon