Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hdf5 to 1.10.6 #6087

Merged
merged 3 commits into from Jul 22, 2020
Merged

Update hdf5 to 1.10.6 #6087

merged 3 commits into from Jul 22, 2020

Conversation

mrodozov
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 16, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mrodozov (Mircho Rodozov) for branch IB/CMSSW_11_2_X/master.

@cmsbuild, @smuzaffar, @mrodozov, @tulamor can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

@Dr15Jones
Copy link

thanks!

@cmsbuild
Copy link
Contributor

-1

Tested at: 6727130

  • Build:

I found compilation error when building:

File "/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc820/external/py2-pip/9.0.3-bcolbf2/lib/python3.8/site-packages/pip/req/req_install.py", line 874, in install
call_subprocess(
File "/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc820/external/py2-pip/9.0.3-bcolbf2/lib/python3.8/site-packages/pip/utils/__init__.py", line 705, in call_subprocess
raise InstallationError(
pip.exceptions.InstallationError: Command "/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc820/external/python3/3.8.2-bcolbf/bin/python3 -u -c "import setuptools, tokenize;__file__='/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/pip-cn2xqk_8-build/setup.py';f=getattr(tokenize, 'open', open)(__file__);code=f.read().replace('\r\n', '\n');f.close();exec(compile(code, __file__, 'exec'))" install --record /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/pip-48gfg9kq-record/install-record.txt --single-version-externally-managed --compile --user --prefix=" failed with error code 1 in /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/pip-cn2xqk_8-build/
error: Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.EkHK3Q (%build)


RPM build errors:
Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.EkHK3Q (%build)



You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5a26b1/8005/summary.html

@mrodozov
Copy link
Contributor Author

oops

@Dr15Jones
Copy link

Any progress?

@mrodozov
Copy link
Contributor Author

I'm building this on cmsdev24 to try fix the externals not building so, no, not much :/

@smuzaffar
Copy link
Contributor

py2-h5py released version does not support hdf5 1.12.0 yet h5py/h5py#1560. You need to get master branch of https://github.com/h5py/h5py

@mrodozov
Copy link
Contributor Author

update is I have built h5py for Python3, but from what I suspect from here:
h5py/h5py#1505
h5py is only available for Python3 now (no surprise if so)
This means keras and keras applications might need only be available for py3 , and all that depends on them, too (meaning tensorflow).
I'm building the entire cmsdist to check

According to h5py/h5py#1505 (comment)
1.10.6 is the latest one working with python2
Above that version only Python3 is supported, and for this we have to move also Keras and Keras-Applications to py3 only, and from there - have only py3 tensorflow.
@mrodozov
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 20, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

Pull request #6087 was updated.

@mrodozov
Copy link
Contributor Author

mrodozov commented Jul 20, 2020

@Dr15Jones is 1.10.6 acceptable (Dec 2019) ? The other scenario might be ... clumsy . See the last commit comment

@cmsbuild
Copy link
Contributor

-1

Tested at: b8131a1

  • Build:

I found compilation error when building:

-rw-rw-r-- root/root      1528 2019-12-24 22:12 hdf5-hdf5-1_10_6/tools/testfiles/zerodim.h5
+ STATUS=0
+ '[' 0 -ne 0 ']'
+ cd hdf5-1.10.6
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.JokZgg: line 39: cd: hdf5-1.10.6: No such file or directory
error: Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.JokZgg (%prep)


RPM build errors:
Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.JokZgg (%prep)



You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5a26b1/8132/summary.html

@mrodozov
Copy link
Contributor Author

test parameters:

  • release = CMSSW_11_2_X_2020-07-18-1100

@mrodozov
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 20, 2020

The tests are being triggered in jenkins.
Test Parameters:

@cmsbuild
Copy link
Contributor

+1
Tested at: 71483e2
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5a26b1/8144/summary.html
CMSSW: CMSSW_11_2_X_2020-07-18-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5a26b1/8144/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2525996
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2525948
  • DQMHistoTests: Total skipped: 47
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 144 log files, 17 edm output root files, 34 DQM output files

@mrodozov mrodozov changed the title Update hdf5 to 1.12.0 Update hdf5 to 1.10.6 Jul 21, 2020
@mrodozov
Copy link
Contributor Author

+externals

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_11_2_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 15a3694 into IB/CMSSW_11_2_X/master Jul 22, 2020
@smuzaffar smuzaffar deleted the mrodozov-patch-2 branch July 27, 2020 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants