Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Revert "Triton v2.3"" #6297

Merged
merged 1 commit into from Oct 14, 2020

Conversation

smuzaffar
Copy link
Contributor

@smuzaffar smuzaffar commented Oct 9, 2020

Reverts #6296
This is same as #6293 which was wrongly merged without the requires cms-sw/cmssw#31715
This should be merged with cms-sw/cmssw#31715
FYI @qliphy , @silviodonato , @kpedro88

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 9, 2020

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_11_2_X/master.

@cmsbuild, @smuzaffar, @mrodozov can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

@smuzaffar
Copy link
Contributor Author

test parameters:

@kpedro88
Copy link
Contributor

kpedro88 commented Oct 9, 2020

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 9, 2020

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmssw#31715

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 9, 2020

-1

Tested at: 72b73ed

  • Build:

I found compilation error when building:

File "./pkgtools/cmsBuild", line 3172, in installApt
if not is_package_installed(pkg, rpm_db_cache): install_reference(pkg)
File "./pkgtools/cmsBuild", line 229, in install_reference
raise RpmInstallFailed(pkg, output)
RpmInstallFailed: Failed to install package gcc-fixincludes. Reason:
error: Failed dependencies:
	external+gcc-fixincludes+1.0 is obsoleted by external+gcc-fixincludes+1.0-1-1000.x86_64
	external+gcc-fixincludes+1.0 is obsoleted by (installed) external+gcc-fixincludes+1.0-1-1000.x86_64

* The action "final-job" was not completed successfully because The following dependencies could not complete:
install-cms+cmsLHEtoEOSManager+2020092400


You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-452733/9835/summary.html

@kpedro88
Copy link
Contributor

kpedro88 commented Oct 9, 2020

@smuzaffar what's the problem here?

@kpedro88
Copy link
Contributor

kpedro88 commented Oct 9, 2020

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 9, 2020

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmssw#31715

@smuzaffar
Copy link
Contributor Author

issue might be with #6294 which I have reverted now.

@smuzaffar
Copy link
Contributor Author

I have restarted the test, should be good now

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 9, 2020

+1
Tested at: 72b73ed
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-452733/9846/summary.html
CMSSW: CMSSW_11_2_X_2020-10-09-1500
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 9, 2020

Comparison job queued.

@kpedro88
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 13, 2020

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmssw#31715

@cmsbuild
Copy link
Contributor

+1
Tested at: 72b73ed
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-452733/9923/summary.html
CMSSW: CMSSW_11_2_X_2020-10-13-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-452733/9923/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2543692
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2543667
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 149 log files, 22 edm output root files, 35 DQM output files

@kpedro88
Copy link
Contributor

@smuzaffar @mrodozov please sign

@silviodonato
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 790e570 into IB/CMSSW_11_2_X/master Oct 14, 2020
@smuzaffar
Copy link
Contributor Author

+externals

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_11_2_X/master IBs (tests are also fine). This pull request will be automatically merged.

@smuzaffar smuzaffar deleted the revert-6296-revert-6293-TritonV2.3 branch October 19, 2020 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants